]> Git Repo - qemu.git/commit
hw/riscv: virt: fix syscon subnode paths
authorConor Dooley <[email protected]>
Wed, 10 Aug 2022 18:46:11 +0000 (19:46 +0100)
committerAlistair Francis <[email protected]>
Wed, 7 Sep 2022 07:18:33 +0000 (09:18 +0200)
commitae29379998f101aedf32f9168135eb0545257b3c
treecfa8467f57452b26e84a360fc26e5aeadd803366
parent95e401d3785a9be9ac4edc7a5a7f9147d917e610
hw/riscv: virt: fix syscon subnode paths

The reset and poweroff features of the syscon were originally added to
top level, which is a valid path for a syscon subnode. Subsequently a
reorganisation was carried out while implementing NUMA in which the
subnodes were moved into the /soc node. As /soc is a "simple-bus", this
path is invalid, and so dt-validate produces the following warnings:

/stuff/qemu/qemu.dtb: soc: poweroff: {'value': [[21845]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-poweroff']} should not be valid under {'type': 'object'}
        From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml
/stuff/qemu/qemu.dtb: soc: reboot: {'value': [[30583]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-reboot']} should not be valid under {'type': 'object'}
        From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml

Move the syscon subnodes back to the top level and silence the warnings.

Reported-by: Rob Herring <[email protected]>
Signed-off-by: Conor Dooley <[email protected]>
Reviewed-by: Alistair Francis <[email protected]>
Message-id: 20220810184612[email protected]
Link: https://lore.kernel.org/linux-riscv/[email protected]/
Fixes: 18df0b4695 ("hw/riscv: virt: Allow creating multiple NUMA sockets")
Signed-off-by: Conor Dooley <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
hw/riscv/virt.c
This page took 0.025986 seconds and 4 git commands to generate.