]> Git Repo - qemu.git/commit
e1000: Don't run e1000_instance_init() twice
authorMarkus Armbruster <[email protected]>
Tue, 5 May 2020 15:29:19 +0000 (17:29 +0200)
committerMarkus Armbruster <[email protected]>
Fri, 15 May 2020 05:07:58 +0000 (07:07 +0200)
commita13f20422dc657719c3fa335788300c7ccf464ee
treed0e83a1e23a15e7c43d9d7399d6562f7fe801b4c
parente508430619b3b26112117b6e06ebc5f8f1d54aed
e1000: Don't run e1000_instance_init() twice

QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().

Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init().  For the concrete subtypes, it duly gets run
twice.  The second run fails, but the error gets ignored (a later
commit will change that).

Remove it from the subtypes.

Cc: Jason Wang <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Acked-by: Jason Wang <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
Message-Id: <20200505152926[email protected]>
hw/net/e1000.c
This page took 0.026679 seconds and 4 git commands to generate.