]> Git Repo - qemu.git/commit
target/mips: Check memory permissions with mem_idx
authorJames Hogan <[email protected]>
Tue, 18 Jul 2017 11:55:53 +0000 (12:55 +0100)
committerYongbok Kim <[email protected]>
Thu, 20 Jul 2017 21:42:26 +0000 (22:42 +0100)
commit9fbf4a58c90183b30bb2c8ad971ccce7e6716a16
tree67ca716a8ee58d9ffb47ffcab4a1a882b78732e6
parent8fffc64696783b1ff1d17262d098976479895660
target/mips: Check memory permissions with mem_idx

When performing virtual to physical address translation, check the
required privilege level based on the mem_idx rather than the mode in
the hflags. This will allow EVA loads & stores to operate safely only on
user memory from kernel mode.

For the cases where the mmu_idx doesn't need to be overridden
(mips_cpu_get_phys_page_debug() and cpu_mips_translate_address()), we
calculate the required mmu_idx using cpu_mmu_index(). Note that this
only tests the MIPS_HFLAG_KSU bits rather than MIPS_HFLAG_MODE, so we
don't test the debug mode hflag MIPS_HFLAG_DM any longer. This should be
fine as get_physical_address() only compares against MIPS_HFLAG_UM and
MIPS_HFLAG_SM, neither of which should get set by compute_hflags() when
MIPS_HFLAG_DM is set.

Signed-off-by: James Hogan <[email protected]>
Reviewed-by: Yongbok Kim <[email protected]>
Cc: Aurelien Jarno <[email protected]>
Signed-off-by: Yongbok Kim <[email protected]>
target/mips/helper.c
This page took 0.026284 seconds and 4 git commands to generate.