]> Git Repo - qemu.git/commit - net/tap-linux.c
give some useful error messages when tap open
authorMichael Tokarev <[email protected]>
Wed, 2 Jun 2010 17:33:01 +0000 (14:33 -0300)
committerAnthony Liguori <[email protected]>
Tue, 22 Jun 2010 20:15:30 +0000 (15:15 -0500)
commit91ca60e01277da2184d9c3f992c440cb5aa264c4
treee86d8211635f69f90b6bbbeec9856cbbb6807cc1
parent49b586a922c1818cbd9f576600f72bff182bc257
give some useful error messages when tap open

In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
(with fprintf) something like this:

  warning: could not open /dev/net/tun: no virtual network emulation

this has 2 issues:
 1) it is not a warning really, it's a fatal error (kvm exits after
that),
 2) there's no indication as of what's actually wrong: printing errno there
    is helpful.

The patch below removes the "warning" prefix, uses %m (since it's linux,
%m is available as format modifier), and changes fprintf() to %qemu_error().
Now it prints something like this instead:

 could not configure /dev/net/tun: Device or resource busy

(there are 2 messages like that in the same function)

This fixes Debian bug #578154, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154

Signed-off-by: Michael Tokarev <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
net/tap-linux.c
This page took 0.026012 seconds and 4 git commands to generate.