]> Git Repo - qemu.git/commit - block/qcow2-refcount.c
qcow2: Read outside array bounds in qcow2_pre_write_overlap_check()
authorLiam Merwick <[email protected]>
Mon, 5 Nov 2018 21:38:39 +0000 (21:38 +0000)
committerMax Reitz <[email protected]>
Mon, 12 Nov 2018 16:49:21 +0000 (17:49 +0100)
commit7cb6d3c9be2cbda05d2b14e7897e74839e48fbb2
tree70693400826a27b43ad493c8a0eb606b24da31df
parent8d9401c2791ee2d2805b741b1ee3006041edcd3e
qcow2: Read outside array bounds in qcow2_pre_write_overlap_check()

The commit for 0e4e4318eaa5 increments QCOW2_OL_MAX_BITNR but does not
add an array entry for QCOW2_OL_BITMAP_DIRECTORY_BITNR to metadata_ol_names[].
As a result, an array dereference of metadata_ol_names[8] in
qcow2_pre_write_overlap_check() could result in a read outside of the array bounds.

Fixes: 0e4e4318eaa5 ('qcow2: add overlap check for bitmap directory')
Cc: Vladimir Sementsov-Ogievskiy <[email protected]>
Signed-off-by: Liam Merwick <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Message-id: 1541453919[email protected]
Signed-off-by: Max Reitz <[email protected]>
block/qcow2-refcount.c
This page took 0.025419 seconds and 4 git commands to generate.