]> Git Repo - qemu.git/commit
block: Don't bother asserting type of output visitor's output
authorMarkus Armbruster <[email protected]>
Fri, 17 Feb 2017 20:38:25 +0000 (21:38 +0100)
committerMarkus Armbruster <[email protected]>
Wed, 22 Feb 2017 18:52:20 +0000 (19:52 +0100)
commit7c81e4e9db5f63635fbf11d66bf08e73d325ae97
tree0124c3507715bb5dc41decd80432d3f158a58a10
parentbbf1028a0ade883cebae5faf984f0e78cb794b17
block: Don't bother asserting type of output visitor's output

After a visit of a complex QAPI type FOO

    ov = qobject_output_visitor_new(&foo);
    visit_type_FOO(ov, NULL, expr, &error_abort);
    visit_complete(ov, &foo);

we can safely assume qobject_type(foo) is QTYPE_QDICT.  We do in many
places, but occasionally assert qobject_type(obj) == QTYPE_QDICT.
Don't.  The appropriate place to check such fundamental properties of
QAPI visitors is the test suite.

Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <1487363905[email protected]>
Reviewed-by: Eric Blake <[email protected]>
block/nbd.c
block/nfs.c
block/qapi.c
This page took 0.025677 seconds and 4 git commands to generate.