]> Git Repo - qemu.git/commit
qapi: Use generated TestStruct machinery in tests
authorEric Blake <[email protected]>
Fri, 6 Nov 2015 06:35:25 +0000 (23:35 -0700)
committerMarkus Armbruster <[email protected]>
Mon, 9 Nov 2015 15:45:05 +0000 (16:45 +0100)
commit748053c97b11039f657525fd7d57a39806d8083e
tree58a89ab8694242fed30fd5da0f64fd15c80bbe4b
parent9d5c1dc117d1ad881bbc76f6990ee1f9e9f8ef7f
qapi: Use generated TestStruct machinery in tests

Commit d88f5fd and friends first introduced the various test-qmp-*
tests in 2011, with duplicated hand-rolled TestStruct machinery,
to make sure the qapi visitor interface was tested.  Later, commit
4f193e3 in 2013 added a .json file for further testing use by the
files, but without consolidating any of the existing hand-rolled
visitors.  And with four copies, subtle differences have crept in,
between the tests themselves (mainly whitespace differences, but
also a question of whether to use NULL or "TestStruct" when
calling visit_start_struct()) and from what the generator produces
(the hand-rolled versions did not cater to partially-allocated
objects, because they did not have a deallocation usage).

Of course, just because the visitor interface is tested does not
mean it is a sane interface; and future patches will be changing
some of the visitor contracts.  Rather than having to duplicate
the cleanup work in each copy of the TestStruct visitor, and keep
each hand-rolled copy in sync with what the generator supplies, we
might as well just test what the generator should give us in the
first place.

Signed-off-by: Eric Blake <[email protected]>
Message-Id: <1446791754[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
tests/qapi-schema/qapi-schema-test.json
tests/qapi-schema/qapi-schema-test.out
tests/test-qmp-input-strict.c
tests/test-qmp-input-visitor.c
tests/test-qmp-output-visitor.c
tests/test-visitor-serialization.c
This page took 0.028172 seconds and 4 git commands to generate.