]> Git Repo - qemu.git/commit - include/block/nbd.h
nbd: Merge nbd_export_bitmap into nbd_export_new
authorEric Blake <[email protected]>
Fri, 11 Jan 2019 19:47:19 +0000 (13:47 -0600)
committerEric Blake <[email protected]>
Mon, 14 Jan 2019 16:09:46 +0000 (10:09 -0600)
commit678ba275c77b5b12f3bc9bb369a1b824fc9f679f
tree9421848ee26b56cfb7a30eaff385d7f621152dd4
parent7dc570b3806e5b0a4c9219061556ed5a4a0de80c
nbd: Merge nbd_export_bitmap into nbd_export_new

We only have one caller that wants to export a bitmap name,
which it does right after creation of the export. But there is
still a brief window of time where an NBD client could see the
export but not the dirty bitmap, which a robust client would
have to interpret as meaning the entire image should be treated
as dirty.  Better is to eliminate the window entirely, by
inlining nbd_export_bitmap() into nbd_export_new(), and refusing
to create the bitmap in the first place if the requested bitmap
can't be located.

We also no longer need logic for setting a different bitmap
name compared to the bitmap being exported.

Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-Id: <20190111194720[email protected]>
blockdev-nbd.c
include/block/nbd.h
nbd/server.c
qemu-nbd.c
This page took 0.021886 seconds and 4 git commands to generate.