]> Git Repo - qemu.git/commit - hw/intc/s390_flic_kvm.c
s390x: fix realize inheritance for kvm-flic
authorHalil Pasic <[email protected]>
Wed, 14 Jun 2017 13:39:48 +0000 (15:39 +0200)
committerChristian Borntraeger <[email protected]>
Wed, 5 Jul 2017 17:44:23 +0000 (19:44 +0200)
commit5cbab1bfdeab274e5d4e3353fa626ba8697eed10
tree6fcc3a8d7bad77aee263a72bbc136e6e6f558e17
parentf62f210943f8290bc0a060f4090046841815a046
s390x: fix realize inheritance for kvm-flic

Commit f6f4ce4211 ("s390x: add property adapter_routes_max_batch",
2016-12-09) introduces a common realize (intended to be common for all
the subclasses) for flic, but fails to make sure the kvm-flic which had
its own is actually calling this common realize.

This omission fortunately does not result in a grave problem. The common
realize was only supposed to catch a possible programming mistake by
validating a value of a property set via the compat machine macros. Since
there was no programming mistake we don't need this fixed for stable.

Let's fix this problem by making sure kvm flic honors the realize of its
parent class.

Let us also improve on the error message we would hypothetically emit
when the validation fails.

Signed-off-by: Halil Pasic <[email protected]>
Fixes: f6f4ce4211 ("s390x: add property adapter_routes_max_batch")
Reviewed-by: Dong Jia Shi <[email protected]>
Reviewed-by: Yi Min Zhao <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
hw/intc/s390_flic.c
hw/intc/s390_flic_kvm.c
This page took 0.026841 seconds and 4 git commands to generate.