]> Git Repo - qemu.git/commit - hw/9pfs/9p-posix-acl.c
9pfs: local: lgetxattr: don't follow symlinks
authorGreg Kurz <[email protected]>
Sun, 26 Feb 2017 22:42:26 +0000 (23:42 +0100)
committerGreg Kurz <[email protected]>
Tue, 28 Feb 2017 10:21:15 +0000 (11:21 +0100)
commit56ad3e54dad6cdcee8668d170df161d89581846f
tree1408dc37298a3c74d867820793ecfc8fd0dfa317
parent996a0d76d7e756e4023ef79bc37bfe629b9eaca7
9pfs: local: lgetxattr: don't follow symlinks

The local_lgetxattr() callback is vulnerable to symlink attacks because
it calls lgetxattr() which follows symbolic links in all path elements but
the rightmost one.

This patch introduces a helper to emulate the non-existing fgetxattrat()
function: it is implemented with /proc/self/fd which provides a trusted
path that can be safely passed to lgetxattr().

local_lgetxattr() is converted to use this helper and opendir_nofollow().

This partly fixes CVE-2016-9602.

Signed-off-by: Greg Kurz <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
hw/9pfs/9p-posix-acl.c
hw/9pfs/9p-util.c
hw/9pfs/9p-util.h
hw/9pfs/9p-xattr-user.c
hw/9pfs/9p-xattr.c
hw/9pfs/9p-xattr.h
This page took 0.026953 seconds and 4 git commands to generate.