]> Git Repo - qemu.git/commit - block/io.c
block: Fix dirty bitmap in bdrv_co_discard
authorFam Zheng <[email protected]>
Mon, 8 Jun 2015 05:56:10 +0000 (13:56 +0800)
committerStefan Hajnoczi <[email protected]>
Thu, 2 Jul 2015 09:06:23 +0000 (10:06 +0100)
commit508249952c0ea7472c62e17bf8132295dab4912d
tree0097014b93cf0e14fe7208b1c1d2123f3201f07c
parentdcfb3beb5130694b76b57de109619fcbf9c7e5b5
block: Fix dirty bitmap in bdrv_co_discard

Unsetting dirty globally with discard is not very correct. The discard may zero
out sectors (depending on can_write_zeroes_with_unmap), we should replicate
this change to destination side to make sure that the guest sees the same data.

Calling bdrv_reset_dirty also troubles mirror job because the hbitmap iterator
doesn't expect unsetting of bits after current position.

So let's do it the opposite way which fixes both problems: set the dirty bits
if we are to discard it.

Reported-by: [email protected]
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
block/io.c
This page took 0.023627 seconds and 4 git commands to generate.