]> Git Repo - qemu.git/commit
pci: designware: Update MSI mapping unconditionally
authorAndrey Smirnov <[email protected]>
Mon, 1 Jul 2019 16:26:15 +0000 (17:26 +0100)
committerPeter Maydell <[email protected]>
Mon, 1 Jul 2019 16:28:59 +0000 (17:28 +0100)
commit4eb42b81c552f9cd4d13bfbf26bbfe95c9cc7072
treee3a0f263e6f5d939dbbd2be8f6e5203aba2665a4
parent6ee51e961e9fadb2c2c1b374531e7aefa38e422d
pci: designware: Update MSI mapping unconditionally

Expression to calculate update_msi_mapping in code handling writes to
DESIGNWARE_PCIE_MSI_INTR0_ENABLE is missing an ! operator and should
be:

    !!root->msi.intr[0].enable ^ !!val;

so that MSI mapping is updated when enabled transitions from either
"none" -> "any" or "any" -> "none". Since that register shouldn't be
written to very often, change the code to update MSI mapping
unconditionally instead of trying to fix the update_msi_mapping logic.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Peter Maydell <[email protected]>
Cc: Michael S. Tsirkin <[email protected]>
Cc: [email protected]
Cc: [email protected]
Acked-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
hw/pci-host/designware.c
This page took 0.025119 seconds and 4 git commands to generate.