]> Git Repo - qemu.git/commit - target-s390x/cpu.h
s390x: reset crypto only on clear reset and QEMU reset
authorDavid Hildenbrand <[email protected]>
Wed, 30 Sep 2015 11:48:45 +0000 (13:48 +0200)
committerCornelia Huck <[email protected]>
Wed, 21 Oct 2015 10:21:30 +0000 (12:21 +0200)
commit4ab729207fe1464b19c6bec609cd545ab717174a
treef2345f04f0128f83a18c50438fd74a847b438acd
parentdb3b2566e0fb45e2901b6f9b842d91db6963915d
s390x: reset crypto only on clear reset and QEMU reset

Initializing VM crypto in initial cpu reset has multiple problems

1. We call the exact same function #VCPU times, although one time is enough
2. On SIGP initial cpu reset, we exchange the wrapping key while
   other VCPUs are running. Bad!
3. It is simply wrong. According to the Pop, a reset happens only during a
   clear reset.

So, we have to reset the keys
- on modified clear reset
- on load clear (QEMU reset - via machine reset)
- on qemu start (via machine reset)

Reviewed-by: Christian Borntraeger <[email protected]>
Signed-off-by: David Hildenbrand <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
hw/s390x/s390-virtio.c
target-s390x/cpu.h
target-s390x/kvm.c
target-s390x/misc_helper.c
This page took 0.02699 seconds and 4 git commands to generate.