]> Git Repo - qemu.git/commit - hw/device-hotplug.c
Support default block interfaces per QEMUMachine
authorChristian Borntraeger <[email protected]>
Tue, 20 Nov 2012 14:30:34 +0000 (15:30 +0100)
committerKevin Wolf <[email protected]>
Tue, 11 Dec 2012 10:05:10 +0000 (11:05 +0100)
commit2d0d2837dcf786da415cf4165d37f4ddd684ff57
tree24a5c080b47b3d5fed294391914ca30949f1fe93
parentc208e8c2d88eea2bbafc2850d8856525637e495d
Support default block interfaces per QEMUMachine

There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to their block devices / drives. Therefore,
this patch introduces a new field default_block_type per QEMUMachine
struct. The prior use_scsi field becomes thereby obsolete and is
replaced through .default_block_type = IF_SCSI.

This patch also changes the default for s390x to IF_VIRTIO and
removes an early hack that converts IF_IDE drives.
Other parties have already claimed interest (e.g. IF_SD for exynos)

To create a sane default, for machines that dont specify a
default_block_type, this patch makes IF_IDE = 0 and IF_NONE = 1.
I checked all users of IF_NONE (blockdev.c and ww/device-hotplug.c)
as well as IF_IDE and it seems that it is ok to change the defines -
in other words, I found no obvious (to me) assumption in the code
regarding IF_NONE==0. IF_NONE is only set if there is an
explicit if=none. Without if=* the interface becomes IF_DEFAULT.

I would suggest to have some additional care, e.g. by letting
this patch sit some days in the block tree.

Based on an initial patch from Einar Lueck <[email protected]>

Signed-off-by: Christian Borntraeger <[email protected]>
CC: Igor Mitsyanko <[email protected]>
CC: Markus Armbruster <[email protected]>
CC: Kevin Wolf <[email protected]>
Reviewed-by: Alexander Graf <[email protected]>
Acked-by: Igor Mitsyanko <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
17 files changed:
blockdev.c
blockdev.h
hw/boards.h
hw/device-hotplug.c
hw/highbank.c
hw/leon3.c
hw/mips_jazz.c
hw/pc_sysfw.c
hw/puv3.c
hw/realview.c
hw/s390-virtio.c
hw/spapr.c
hw/sun4m.c
hw/versatilepb.c
hw/vexpress.c
hw/xilinx_zynq.c
vl.c
This page took 0.031553 seconds and 4 git commands to generate.