]> Git Repo - qemu.git/commit
virtio: fix vhost handling
authorPaolo Bonzini <[email protected]>
Mon, 6 Aug 2012 13:26:14 +0000 (15:26 +0200)
committerAnthony Liguori <[email protected]>
Mon, 6 Aug 2012 19:01:44 +0000 (14:01 -0500)
commit26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad
tree0cc5a4e68907acbaeac1c791cf076349b707a32e
parent22d48de65c88c42e3cb2b000491dc6089a240e2a
virtio: fix vhost handling

Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net
because it always registers the virtio_pci_host_notifier_read() handler
function on the ioeventfd, even when vhost_net.ko is using the ioeventfd.
The result is both QEMU and vhost_net.ko polling on the same eventfd
and the virtio_net.ko guest driver seeing inconsistent results:

  # ifconfig eth0 192.168.0.1 netmask 255.255.255.0
  virtio_net virtio0: output:id 0 is not a head!

To fix this, proceed the same as we do for irqfd: add a parameter to
virtio_queue_set_host_notifier_fd_handler and in that case only set
the notifier, not the handler.

Cc: Stefan Hajnoczi <[email protected]>
Tested-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
hw/virtio-pci.c
hw/virtio.c
hw/virtio.h
This page took 0.026785 seconds and 4 git commands to generate.