]> Git Repo - qemu.git/commit
dbus-vmstate: Increase the size of input stream buffer used during load
authorPriyankar Jain <[email protected]>
Tue, 2 Feb 2021 13:54:20 +0000 (13:54 +0000)
committerMarc-André Lureau <[email protected]>
Thu, 1 Apr 2021 11:27:44 +0000 (15:27 +0400)
commit1d9fa7a859ac78e1809a376a4f2a443290e755e0
tree74385854fdb3e306f69784cb53a0f1cbcd4ba168
parent64e16fbbf49ce81b37841480d14b0caf5753c98e
dbus-vmstate: Increase the size of input stream buffer used during load

This commit fixes an issue where migration is failing in the load phase
because of a false alarm about data unavailability.

Following is the error received when the amount of data to be transferred
exceeds the default buffer size setup by G_BUFFERED_INPUT_STREAM(4KiB),
even when the maximum data size supported by this backend is 1MiB
(DBUS_VMSTATE_SIZE_LIMIT):

  dbus_vmstate_post_load: Invalid vmstate size: 4364
  qemu-kvm: error while loading state for instance 0x0 of device 'dbus-vmstate/dbus-vmstate'

This commit sets the size of the input stream buffer used during load to
DBUS_VMSTATE_SIZE_LIMIT which is the maximum amount of data a helper can
send during save phase.
Secondly, this commit makes sure that the input stream buffer is loaded before
checking the size of the data available in it, rectifying the false alarm about
data unavailability.

Fixes: 5010cec2bc87 ("Add dbus-vmstate object")
Signed-off-by: Priyankar Jain <[email protected]>
Message-Id: <cdaad4718e62bf22fd5e93ef3e252de20da5c17c.1612273156[email protected]>
[ Modified printf format for gsize ]
Reviewed-by: Marc-André Lureau <[email protected]>
backends/dbus-vmstate.c
This page took 0.026656 seconds and 4 git commands to generate.