]> Git Repo - qemu.git/commit
Work around dhclient brokenness
authorAnthony Liguori <[email protected]>
Thu, 22 Oct 2009 16:43:48 +0000 (17:43 +0100)
committerAnthony Liguori <[email protected]>
Tue, 27 Oct 2009 17:29:04 +0000 (12:29 -0500)
commit1d41b0c1ec66d38355a1e76c29dd2200433335f6
tree0b088fd96cff908d0441d19823437333a784504b
parentf5436dd96aea2ec937964230831f241ebd3b658b
Work around dhclient brokenness

With the latest GSO/csum offload patches, any guest using an unpatched version
of dhclient (any Ubuntu guest, for instance), will no longer be able to get
a DHCP address.

dhclient is actually at fault here.  It uses AF_PACKET to receive DHCP responses
but does not check auxdata to see if the packet has a valid csum.  This causes
it to throw out the DHCP responses it gets from the virtio interface as there
is not a valid checksum.

Fedora has carried a patch to fix their dhclient (it's needed for Xen too) but
this patch has not made it into a release of dhclient.  AFAIK, the patch is in
the dhclient CVS but I cannot confirm since their CVS is not public.

This patch, suggested by Rusty, looks for UDP packets (of a normal MTU) and
explicitly adds a checksum to them if they are missing one.

This allows unpatched dhclients to continue to work without needing to update
the guest kernels.

Signed-off-by: Anthony Liguori <[email protected]>
Signed-off-by: Mark McLoughlin <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
hw/virtio-net.c
This page took 0.021613 seconds and 4 git commands to generate.