]> Git Repo - qemu.git/commit
softfloat: Handle default NaN mode after pickNaNMulAdd, not before
authorPeter Maydell <[email protected]>
Thu, 10 May 2018 17:10:56 +0000 (18:10 +0100)
committerPeter Maydell <[email protected]>
Thu, 10 May 2018 17:10:56 +0000 (18:10 +0100)
commit1839189bbf89889076aadf0c793c1b57977b28d7
treedba046235c19790228dc3e845002fc0a5fda5828
parent7a35383afd66458ff11fa5c72a1599f3a24f3073
softfloat: Handle default NaN mode after pickNaNMulAdd, not before

It is implementation defined whether a multiply-add of
(0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or
not, so we let the target-specific pickNaNMulAdd function
handle this. This means that we must do the "return the
default NaN in default NaN mode" check after the call,
not before. Correct the ordering, and restore the comment
from the old propagateFloat64MulAddNaN() that warned about
this corner case.

This fixes a regression from 2.11 for Arm guests where we would
incorrectly fail to set the Invalid flag for these cases.

Cc: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Reviewed-by: Alex Bennée <[email protected]>
Tested-by: Alex Bennée <[email protected]>
Message-id: 20180504100547[email protected]
fpu/softfloat.c
This page took 0.026905 seconds and 4 git commands to generate.