]> Git Repo - qemu.git/commit
hw/block/pflash_cfi02: Rewrite a fall through comment
authorPhilippe Mathieu-Daudé <[email protected]>
Fri, 19 Jul 2019 12:40:48 +0000 (14:40 +0200)
committerPhilippe Mathieu-Daudé <[email protected]>
Tue, 23 Jul 2019 09:31:07 +0000 (11:31 +0200)
commit124e4cfaa42bb5a14eec33ea47d3502b5f46eb33
treee33d2aa7431235315d7efcf518683d6818fb79b9
parent3a283507c03474d285196620fca506bd1a89b198
hw/block/pflash_cfi02: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  hw/block/pflash_cfi02.c: In function ‘pflash_write’:
  hw/block/pflash_cfi02.c:574:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
    574 |             if (boff == 0x55 && cmd == 0x98) {
        |                ^
  hw/block/pflash_cfi02.c:581:9: note: here
    581 |         default:
        |         ^~~~~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-Id: <20190719131425[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
hw/block/pflash_cfi02.c
This page took 0.025991 seconds and 4 git commands to generate.