]> Git Repo - qemu.git/commit
tests/iothread: Always connect iothread GSource to a GMainContext
authorPeter Maydell <[email protected]>
Mon, 6 Jan 2020 14:45:52 +0000 (14:45 +0000)
committerPeter Maydell <[email protected]>
Tue, 7 Jan 2020 14:32:57 +0000 (14:32 +0000)
commit0cb04061728a5e6cf579c43b8c3695fb70d07697
treea4a048542ba2805235d9ff1afe1965b3d0a51a52
parenta8f2c60cef0ab7548e8160437546f24c2ce5cf9e
tests/iothread: Always connect iothread GSource to a GMainContext

On older versions of glib (anything prior to glib commit 0f056ebe
from May 2019), the implementation of g_source_ref() and
g_source_unref() is not threadsafe for a GSource which is not
attached to a GMainContext.

QEMU's real iothread.c implementation always attaches its
iothread->ctx's GSource to a GMainContext created for that iothread,
so it is OK, but the simple test framework implementation in
tests/iothread.c was not doing this.  This was causing intermittent
assertion failures in the test-aio-multithread subtest
"/aio/multi/mutex/contended" test on the BSD hosts.  (It's unclear
why only BSD seems to have been affected -- perhaps a combination of
the specific glib version being used in the VMs and their happening
to run on a host with a lot of CPUs).

Borrow the iothread_init_gcontext() from the real iothread.c
and add the corresponding cleanup code and the calls to
g_main_context_push/pop_thread_default() so we actually use
the GMainContext we create.

Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Marc-AndrĂ© Lureau <[email protected]>
Reviewed-by: Peter Xu <[email protected]>
Message-id: 20200106144552[email protected]
tests/iothread.c
This page took 0.022264 seconds and 4 git commands to generate.