]> Git Repo - qemu.git/commit
qom: Fix regression with 'qom-type'
authorEric Blake <[email protected]>
Thu, 23 Mar 2017 16:03:15 +0000 (11:03 -0500)
committerPeter Maydell <[email protected]>
Thu, 23 Mar 2017 17:59:40 +0000 (17:59 +0000)
commit08329701199449bde497570dcfdb9c86062baf20
treecdc35825cf64ed82f2eb1e2c1d1da47e84550d22
parentc50126aac1e80f3ab255fbceffff953f5f17e4df
qom: Fix regression with 'qom-type'

Commit 9a6d1ac assumed that 'qom-type' could be removed from QemuOpts
with no ill effects.  However, this command line proves otherwise:

$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \
  -object rng-random,filename=/dev/urandom,id=rng0 \
  -device virtio-rng-pci,rng=rng0
qemu-system-x86_64: -object rng-random,filename=/dev/urandom,id=rng0: Parameter 'qom-type' is missing

Fix the regression by restoring qom-type in opts after its temporary
removal that was needed for the duration of user_creatable_add_opts().

Reported-by: Richard W. M. Jones <[email protected]>
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Tested-by: Richard W.M. Jones <[email protected]>
Message-id: 20170323160315[email protected]
Signed-off-by: Peter Maydell <[email protected]>
qom/object_interfaces.c
This page took 0.024889 seconds and 4 git commands to generate.