]> Git Repo - qemu.git/commit - ui/vnc.c
Revert "vnc: allow fall back to RAW encoding"
authorGerd Hoffmann <[email protected]>
Tue, 21 Jan 2020 06:02:10 +0000 (07:02 +0100)
committerGerd Hoffmann <[email protected]>
Tue, 21 Jan 2020 06:09:56 +0000 (07:09 +0100)
commit0780ec7be82dd4781e9fd216b5d99a125882ff5a
treef334913dbd886acce3a370aed786ece2b2eda8b9
parent43d1455cf84283466e5c22a217db5ef4b8197b14
Revert "vnc: allow fall back to RAW encoding"

This reverts commit de3f7de7f4e257ce44cdabb90f5f17ee99624557.

Remove VNC optimization to reencode framebuffer update as raw if it's
smaller than the default encoding.

QEMU's implementation was naive and didn't account for the ZLIB z_stream
mutating with each compression.  Because of the mutation, simply
resetting the output buffer's offset wasn't sufficient to "rewind" the
operation.  The mutated z_stream would generate future zlib blocks which
referred to symbols in past blocks which weren't sent.  This would lead
to artifacting.

Considering that ZRLE is never larger than raw and even though ZLIB can
occasionally be fractionally larger than raw, the overhead of
implementing this optimization correctly isn't worth it.

Signed-off-by: Cameron Esfahani <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
ui/vnc.c
This page took 0.025109 seconds and 4 git commands to generate.