nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

[qemu.git] / qemu-io.c

diff --git a/qemu-io.c b/qemu-io.c
index d6690289b82bcdd19cc420d3c3ce5892b5df8f27..8e41080cc9b9eec8acbd67f7838440d6d51a3b65 100644 (file)
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -19,15 +19,15 @@
 #include "qemu/option.h"
 #include "qemu/config-file.h"
 #include "qemu/readline.h"
 #include "qemu/option.h"
 #include "qemu/config-file.h"
 #include "qemu/readline.h"

+#include "sysemu/block-backend.h"

 #include "block/block_int.h"
 #include "trace/control.h"
 
 #define CMD_NOFILE_OK   0x01
 
 #include "block/block_int.h"
 #include "trace/control.h"
 
 #define CMD_NOFILE_OK   0x01
 

-char *progname;
+static char *progname;

 
 

-BlockDriverState *qemuio_bs;
-extern int qemuio_misalign;
+static BlockBackend *qemuio_blk;

 
 /* qemu-io commands passed using -c */
 static int ncmdline;
 
 /* qemu-io commands passed using -c */
 static int ncmdline;


@@ -35,10 +35,10 @@ static char **cmdline;
 
 static ReadLineState *readline_state;
 
 
 static ReadLineState *readline_state;
 

-static int close_f(BlockDriverState *bs, int argc, char **argv)
+static int close_f(BlockBackend *blk, int argc, char **argv)

 {
 {

-    bdrv_unref(bs);
-    qemuio_bs = NULL;
+    blk_unref(qemuio_blk);
+    qemuio_blk = NULL;

     return 0;
 }
 
     return 0;
 }
 


@@ -49,33 +49,23 @@ static const cmdinfo_t close_cmd = {
     .oneline    = "close the current open file",
 };
 
     .oneline    = "close the current open file",
 };
 

-static int openfile(char *name, int flags, int growable, QDict *opts)
+static int openfile(char *name, int flags, QDict *opts)

 {
     Error *local_err = NULL;
 
 {
     Error *local_err = NULL;
 

-    if (qemuio_bs) {
+    if (qemuio_blk) {

         fprintf(stderr, "file open already, try 'help close'\n");
         fprintf(stderr, "file open already, try 'help close'\n");

+        QDECREF(opts);

         return 1;
     }
 
         return 1;
     }
 

-    if (growable) {
-        if (bdrv_file_open(&qemuio_bs, name, NULL, opts, flags, &local_err)) {
-            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
-                    error_get_pretty(local_err));
-            error_free(local_err);
-            return 1;
-        }
-    } else {
-        qemuio_bs = bdrv_new("hda");
-
-        if (bdrv_open(qemuio_bs, name, opts, flags, NULL, &local_err) < 0) {
-            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,
-                    error_get_pretty(local_err));
-            error_free(local_err);
-            bdrv_unref(qemuio_bs);
-            qemuio_bs = NULL;
-            return 1;
-        }
+    qemuio_blk = blk_new_open("hda", name, NULL, opts, flags, &local_err);
+    if (!qemuio_blk) {
+        fprintf(stderr, "%s: can't open%s%s: %s\n", progname,
+                name ? " device " : "", name ?: "",
+                error_get_pretty(local_err));
+        error_free(local_err);
+        return 1;

     }
 
     return 0;
     }
 
     return 0;


@@ -94,12 +84,11 @@ static void open_help(void)
 " -r, -- open file read-only\n"
 " -s, -- use snapshot file\n"
 " -n, -- disable host cache\n"
 " -r, -- open file read-only\n"
 " -s, -- use snapshot file\n"
 " -n, -- disable host cache\n"

-" -g, -- allow file to grow (only applies to protocols)\n"

 " -o, -- options to be given to the block driver"
 "\n");
 }
 
 " -o, -- options to be given to the block driver"
 "\n");
 }
 

-static int open_f(BlockDriverState *bs, int argc, char **argv);
+static int open_f(BlockBackend *blk, int argc, char **argv);

 
 static const cmdinfo_t open_cmd = {
     .name       = "open",
 
 static const cmdinfo_t open_cmd = {
     .name       = "open",


@@ -115,6 +104,7 @@ static const cmdinfo_t open_cmd = {
 
 static QemuOptsList empty_opts = {
     .name = "drive",
 
 static QemuOptsList empty_opts = {
     .name = "drive",

+    .merge_lists = true,

     .head = QTAILQ_HEAD_INITIALIZER(empty_opts.head),
     .desc = {
         /* no elements => accept any params */
     .head = QTAILQ_HEAD_INITIALIZER(empty_opts.head),
     .desc = {
         /* no elements => accept any params */


@@ -122,14 +112,13 @@ static QemuOptsList empty_opts = {
     },
 };
 
     },
 };
 

-static int open_f(BlockDriverState *bs, int argc, char **argv)
+static int open_f(BlockBackend *blk, int argc, char **argv)

 {
     int flags = 0;
     int readonly = 0;
 {
     int flags = 0;
     int readonly = 0;

-    int growable = 0;

     int c;
     QemuOpts *qopts;
     int c;
     QemuOpts *qopts;

-    QDict *opts = NULL;
+    QDict *opts;

 
     while ((c = getopt(argc, argv, "snrgo:")) != EOF) {
         switch (c) {
 
     while ((c = getopt(argc, argv, "snrgo:")) != EOF) {
         switch (c) {


@@ -142,19 +131,15 @@ static int open_f(BlockDriverState *bs, int argc, char **argv)
         case 'r':
             readonly = 1;
             break;
         case 'r':
             readonly = 1;
             break;

-        case 'g':
-            growable = 1;
-            break;

         case 'o':
         case 'o':

-            qopts = qemu_opts_parse(&empty_opts, optarg, 0);
-            if (qopts == NULL) {
+            if (!qemu_opts_parse(&empty_opts, optarg, 0)) {

                 printf("could not parse option list -- %s\n", optarg);
                 printf("could not parse option list -- %s\n", optarg);

+                qemu_opts_reset(&empty_opts);

                 return 0;
             }
                 return 0;
             }

-            opts = qemu_opts_to_qdict(qopts, opts);
-            qemu_opts_del(qopts);

             break;
         default:
             break;
         default:

+            qemu_opts_reset(&empty_opts);

             return qemuio_command_usage(&open_cmd);
         }
     }
             return qemuio_command_usage(&open_cmd);
         }
     }


@@ -163,16 +148,21 @@ static int open_f(BlockDriverState *bs, int argc, char **argv)
         flags |= BDRV_O_RDWR;
     }
 
         flags |= BDRV_O_RDWR;
     }
 

+    qopts = qemu_opts_find(&empty_opts, NULL);
+    opts = qopts ? qemu_opts_to_qdict(qopts, NULL) : NULL;
+    qemu_opts_reset(&empty_opts);
+

     if (optind == argc - 1) {
     if (optind == argc - 1) {

-        return openfile(argv[optind], flags, growable, opts);
+        return openfile(argv[optind], flags, opts);

     } else if (optind == argc) {
     } else if (optind == argc) {

-        return openfile(NULL, flags, growable, opts);
+        return openfile(NULL, flags, opts);

     } else {
     } else {

+        QDECREF(opts);

         return qemuio_command_usage(&open_cmd);
     }
 }
 
         return qemuio_command_usage(&open_cmd);
     }
 }
 

-static int quit_f(BlockDriverState *bs, int argc, char **argv)
+static int quit_f(BlockBackend *blk, int argc, char **argv)

 {
     return 1;
 }
 {
     return 1;
 }


@@ -190,22 +180,25 @@ static const cmdinfo_t quit_cmd = {
 static void usage(const char *name)
 {
     printf(
 static void usage(const char *name)
 {
     printf(

-"Usage: %s [-h] [-V] [-rsnm] [-c cmd] ... [file]\n"
+"Usage: %s [-h] [-V] [-rsnm] [-f FMT] [-c STRING] ... [file]\n"

 "QEMU Disk exerciser\n"
 "\n"
 "QEMU Disk exerciser\n"
 "\n"

-"  -c, --cmd            command to execute\n"
+"  -c, --cmd STRING     execute command with its arguments\n"
+"                       from the given string\n"
+"  -f, --format FMT     specifies the block driver to use\n"

 "  -r, --read-only      export read-only\n"
 "  -s, --snapshot       use snapshot file\n"
 "  -n, --nocache        disable host cache\n"
 "  -r, --read-only      export read-only\n"
 "  -s, --snapshot       use snapshot file\n"
 "  -n, --nocache        disable host cache\n"

-"  -g, --growable       allow file to grow (only applies to protocols)\n"

 "  -m, --misalign       misalign allocations for O_DIRECT\n"
 "  -k, --native-aio     use kernel AIO implementation (on Linux only)\n"
 "  -t, --cache=MODE     use the given cache mode for the image\n"
 "  -T, --trace FILE     enable trace events listed in the given file\n"
 "  -h, --help           display this help and exit\n"
 "  -V, --version        output version information and exit\n"
 "  -m, --misalign       misalign allocations for O_DIRECT\n"
 "  -k, --native-aio     use kernel AIO implementation (on Linux only)\n"
 "  -t, --cache=MODE     use the given cache mode for the image\n"
 "  -T, --trace FILE     enable trace events listed in the given file\n"
 "  -h, --help           display this help and exit\n"
 "  -V, --version        output version information and exit\n"

+"\n"
+"See '%s -c help' for information on available commands."

 "\n",
 "\n",

-    name);
+    name, name);

 }
 
 static char *get_prompt(void)
 }
 
 static char *get_prompt(void)


@@ -219,7 +212,8 @@ static char *get_prompt(void)
     return prompt;
 }
 
     return prompt;
 }
 

-static void readline_printf_func(void *opaque, const char *fmt, ...)
+static void GCC_FMT_ATTR(2, 3) readline_printf_func(void *opaque,
+                                                    const char *fmt, ...)

 {
     va_list ap;
     va_start(ap, fmt);
 {
     va_list ap;
     va_start(ap, fmt);


@@ -305,7 +299,7 @@ static void command_loop(void)
     char *input;
 
     for (i = 0; !done && i < ncmdline; i++) {
     char *input;
 
     for (i = 0; !done && i < ncmdline; i++) {

-        done = qemuio_command(qemuio_bs, cmdline[i]);
+        done = qemuio_command(qemuio_blk, cmdline[i]);

     }
     if (cmdline) {
         g_free(cmdline);
     }
     if (cmdline) {
         g_free(cmdline);


@@ -330,7 +324,7 @@ static void command_loop(void)
         if (input == NULL) {
             break;
         }
         if (input == NULL) {
             break;
         }

-        done = qemuio_command(qemuio_bs, input);
+        done = qemuio_command(qemuio_blk, input);

         g_free(input);
 
         prompted = 0;
         g_free(input);
 
         prompted = 0;


@@ -341,7 +335,7 @@ static void command_loop(void)
 
 static void add_user_command(char *optarg)
 {
 
 static void add_user_command(char *optarg)
 {

-    cmdline = g_realloc(cmdline, ++ncmdline * sizeof(char *));
+    cmdline = g_renew(char *, cmdline, ++ncmdline);

     cmdline[ncmdline-1] = optarg;
 }
 
     cmdline[ncmdline-1] = optarg;
 }
 


@@ -353,18 +347,17 @@ static void reenable_tty_echo(void)
 int main(int argc, char **argv)
 {
     int readonly = 0;
 int main(int argc, char **argv)
 {
     int readonly = 0;

-    int growable = 0;
-    const char *sopt = "hVc:d:rsnmgkt:T:";
+    const char *sopt = "hVc:d:f:rsnmgkt:T:";

     const struct option lopt[] = {
         { "help", 0, NULL, 'h' },
         { "version", 0, NULL, 'V' },
         { "offset", 1, NULL, 'o' },
         { "cmd", 1, NULL, 'c' },
     const struct option lopt[] = {
         { "help", 0, NULL, 'h' },
         { "version", 0, NULL, 'V' },
         { "offset", 1, NULL, 'o' },
         { "cmd", 1, NULL, 'c' },

+        { "format", 1, NULL, 'f' },

         { "read-only", 0, NULL, 'r' },
         { "snapshot", 0, NULL, 's' },
         { "nocache", 0, NULL, 'n' },
         { "misalign", 0, NULL, 'm' },
         { "read-only", 0, NULL, 'r' },
         { "snapshot", 0, NULL, 's' },
         { "nocache", 0, NULL, 'n' },
         { "misalign", 0, NULL, 'm' },

-        { "growable", 0, NULL, 'g' },

         { "native-aio", 0, NULL, 'k' },
         { "discard", 1, NULL, 'd' },
         { "cache", 1, NULL, 't' },
         { "native-aio", 0, NULL, 'k' },
         { "discard", 1, NULL, 'd' },
         { "cache", 1, NULL, 't' },


@@ -374,12 +367,17 @@ int main(int argc, char **argv)
     int c;
     int opt_index = 0;
     int flags = BDRV_O_UNMAP;
     int c;
     int opt_index = 0;
     int flags = BDRV_O_UNMAP;

+    Error *local_error = NULL;
+    QDict *opts = NULL;

 
 #ifdef CONFIG_POSIX
     signal(SIGPIPE, SIG_IGN);
 #endif
 
     progname = basename(argv[0]);
 
 #ifdef CONFIG_POSIX
     signal(SIGPIPE, SIG_IGN);
 #endif
 
     progname = basename(argv[0]);

+    qemu_init_exec_dir(argv[0]);
+
+    bdrv_init();

 
     while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) {
         switch (c) {
 
     while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) {
         switch (c) {


@@ -395,6 +393,12 @@ int main(int argc, char **argv)
                 exit(1);
             }
             break;
                 exit(1);
             }
             break;

+        case 'f':
+            if (!opts) {
+                opts = qdict_new();
+            }
+            qdict_put(opts, "driver", qstring_from_str(optarg));
+            break;

         case 'c':
             add_user_command(optarg);
             break;
         case 'c':
             add_user_command(optarg);
             break;


@@ -402,10 +406,7 @@ int main(int argc, char **argv)
             readonly = 1;
             break;
         case 'm':
             readonly = 1;
             break;
         case 'm':

-            qemuio_misalign = 1;
-            break;
-        case 'g':
-            growable = 1;
+            qemuio_misalign = true;

             break;
         case 'k':
             flags |= BDRV_O_NATIVE_AIO;
             break;
         case 'k':
             flags |= BDRV_O_NATIVE_AIO;


@@ -417,7 +418,7 @@ int main(int argc, char **argv)
             }
             break;
         case 'T':
             }
             break;
         case 'T':

-            if (!trace_backend_init(optarg, NULL)) {
+            if (!trace_init_backends(optarg, NULL)) {

                 exit(1); /* error message will have been printed */
             }
             break;
                 exit(1); /* error message will have been printed */
             }
             break;


@@ -438,8 +439,10 @@ int main(int argc, char **argv)
         exit(1);
     }
 
         exit(1);
     }
 

-    qemu_init_main_loop();
-    bdrv_init();
+    if (qemu_init_main_loop(&local_error)) {
+        error_report_err(local_error);
+        exit(1);
+    }

 
     /* initialize commands */
     qemuio_add_command(&quit_cmd);
 
     /* initialize commands */
     qemuio_add_command(&quit_cmd);


@@ -461,7 +464,7 @@ int main(int argc, char **argv)
     }
 
     if ((argc - optind) == 1) {
     }
 
     if ((argc - optind) == 1) {

-        openfile(argv[optind], flags, growable, NULL);
+        openfile(argv[optind], flags, opts);

     }
     command_loop();
 
     }
     command_loop();
 


@@ -470,9 +473,7 @@ int main(int argc, char **argv)
      */
     bdrv_drain_all();
 
      */
     bdrv_drain_all();
 

-    if (qemuio_bs) {
-        bdrv_unref(qemuio_bs);
-    }
+    blk_unref(qemuio_blk);

     g_free(readline_state);
     return 0;
 }
     g_free(readline_state);
     return 0;
 }