]>
Commit | Line | Data |
---|---|---|
893f7eba PB |
1 | /* |
2 | * Image mirroring | |
3 | * | |
4 | * Copyright Red Hat, Inc. 2012 | |
5 | * | |
6 | * Authors: | |
7 | * Paolo Bonzini <[email protected]> | |
8 | * | |
9 | * This work is licensed under the terms of the GNU LGPL, version 2 or later. | |
10 | * See the COPYING.LIB file in the top-level directory. | |
11 | * | |
12 | */ | |
13 | ||
80c71a24 | 14 | #include "qemu/osdep.h" |
fd4a6493 | 15 | #include "qemu/cutils.h" |
893f7eba | 16 | #include "trace.h" |
c87621ea | 17 | #include "block/blockjob_int.h" |
737e150e | 18 | #include "block/block_int.h" |
373340b2 | 19 | #include "sysemu/block-backend.h" |
da34e65c | 20 | #include "qapi/error.h" |
cc7a8ea7 | 21 | #include "qapi/qmp/qerror.h" |
893f7eba | 22 | #include "qemu/ratelimit.h" |
b812f671 | 23 | #include "qemu/bitmap.h" |
893f7eba | 24 | |
402a4741 | 25 | #define MAX_IN_FLIGHT 16 |
b436982f EB |
26 | #define MAX_IO_BYTES (1 << 20) /* 1 Mb */ |
27 | #define DEFAULT_MIRROR_BUF_SIZE (MAX_IN_FLIGHT * MAX_IO_BYTES) | |
402a4741 PB |
28 | |
29 | /* The mirroring buffer is a list of granularity-sized chunks. | |
30 | * Free chunks are organized in a list. | |
31 | */ | |
32 | typedef struct MirrorBuffer { | |
33 | QSIMPLEQ_ENTRY(MirrorBuffer) next; | |
34 | } MirrorBuffer; | |
893f7eba PB |
35 | |
36 | typedef struct MirrorBlockJob { | |
37 | BlockJob common; | |
e253f4b8 | 38 | BlockBackend *target; |
4ef85a9c KW |
39 | BlockDriverState *mirror_top_bs; |
40 | BlockDriverState *source; | |
5bc361b8 | 41 | BlockDriverState *base; |
4ef85a9c | 42 | |
09158f00 BC |
43 | /* The name of the graph node to replace */ |
44 | char *replaces; | |
45 | /* The BDS to replace */ | |
46 | BlockDriverState *to_replace; | |
47 | /* Used to block operations on the drive-mirror-replace target */ | |
48 | Error *replace_blocker; | |
03544a6e | 49 | bool is_none_mode; |
274fccee | 50 | BlockMirrorBackingMode backing_mode; |
b952b558 | 51 | BlockdevOnError on_source_error, on_target_error; |
d63ffd87 PB |
52 | bool synced; |
53 | bool should_complete; | |
eee13dfe | 54 | int64_t granularity; |
b812f671 | 55 | size_t buf_size; |
b21c7652 | 56 | int64_t bdev_length; |
b812f671 | 57 | unsigned long *cow_bitmap; |
e4654d2d | 58 | BdrvDirtyBitmap *dirty_bitmap; |
dc162c8e | 59 | BdrvDirtyBitmapIter *dbi; |
893f7eba | 60 | uint8_t *buf; |
402a4741 PB |
61 | QSIMPLEQ_HEAD(, MirrorBuffer) buf_free; |
62 | int buf_free_count; | |
bd48bde8 | 63 | |
49efb1f5 | 64 | uint64_t last_pause_ns; |
402a4741 | 65 | unsigned long *in_flight_bitmap; |
bd48bde8 | 66 | int in_flight; |
b436982f | 67 | int64_t bytes_in_flight; |
bd48bde8 | 68 | int ret; |
0fc9f8ea | 69 | bool unmap; |
e424aff5 | 70 | bool waiting_for_io; |
b436982f | 71 | int target_cluster_size; |
e5b43573 | 72 | int max_iov; |
90ab48eb | 73 | bool initial_zeroing_ongoing; |
893f7eba PB |
74 | } MirrorBlockJob; |
75 | ||
bd48bde8 PB |
76 | typedef struct MirrorOp { |
77 | MirrorBlockJob *s; | |
78 | QEMUIOVector qiov; | |
b436982f EB |
79 | int64_t offset; |
80 | uint64_t bytes; | |
bd48bde8 PB |
81 | } MirrorOp; |
82 | ||
b952b558 PB |
83 | static BlockErrorAction mirror_error_action(MirrorBlockJob *s, bool read, |
84 | int error) | |
85 | { | |
86 | s->synced = false; | |
87 | if (read) { | |
81e254dc KW |
88 | return block_job_error_action(&s->common, s->on_source_error, |
89 | true, error); | |
b952b558 | 90 | } else { |
81e254dc KW |
91 | return block_job_error_action(&s->common, s->on_target_error, |
92 | false, error); | |
b952b558 PB |
93 | } |
94 | } | |
95 | ||
bd48bde8 PB |
96 | static void mirror_iteration_done(MirrorOp *op, int ret) |
97 | { | |
98 | MirrorBlockJob *s = op->s; | |
402a4741 | 99 | struct iovec *iov; |
bd48bde8 | 100 | int64_t chunk_num; |
b436982f | 101 | int i, nb_chunks; |
bd48bde8 | 102 | |
b436982f | 103 | trace_mirror_iteration_done(s, op->offset, op->bytes, ret); |
bd48bde8 PB |
104 | |
105 | s->in_flight--; | |
b436982f | 106 | s->bytes_in_flight -= op->bytes; |
402a4741 PB |
107 | iov = op->qiov.iov; |
108 | for (i = 0; i < op->qiov.niov; i++) { | |
109 | MirrorBuffer *buf = (MirrorBuffer *) iov[i].iov_base; | |
110 | QSIMPLEQ_INSERT_TAIL(&s->buf_free, buf, next); | |
111 | s->buf_free_count++; | |
112 | } | |
113 | ||
b436982f EB |
114 | chunk_num = op->offset / s->granularity; |
115 | nb_chunks = DIV_ROUND_UP(op->bytes, s->granularity); | |
402a4741 | 116 | bitmap_clear(s->in_flight_bitmap, chunk_num, nb_chunks); |
b21c7652 HR |
117 | if (ret >= 0) { |
118 | if (s->cow_bitmap) { | |
119 | bitmap_set(s->cow_bitmap, chunk_num, nb_chunks); | |
120 | } | |
90ab48eb | 121 | if (!s->initial_zeroing_ongoing) { |
30a5c887 | 122 | job_progress_update(&s->common.job, op->bytes); |
90ab48eb | 123 | } |
bd48bde8 | 124 | } |
6df3bf8e | 125 | qemu_iovec_destroy(&op->qiov); |
c84b3192 | 126 | g_free(op); |
7b770c72 | 127 | |
e424aff5 | 128 | if (s->waiting_for_io) { |
da01ff7f | 129 | qemu_coroutine_enter(s->common.job.co); |
7b770c72 | 130 | } |
bd48bde8 PB |
131 | } |
132 | ||
133 | static void mirror_write_complete(void *opaque, int ret) | |
134 | { | |
135 | MirrorOp *op = opaque; | |
136 | MirrorBlockJob *s = op->s; | |
b9e413dd PB |
137 | |
138 | aio_context_acquire(blk_get_aio_context(s->common.blk)); | |
bd48bde8 | 139 | if (ret < 0) { |
bd48bde8 PB |
140 | BlockErrorAction action; |
141 | ||
e0d7f73e | 142 | bdrv_set_dirty_bitmap(s->dirty_bitmap, op->offset, op->bytes); |
bd48bde8 | 143 | action = mirror_error_action(s, false, -ret); |
a589569f | 144 | if (action == BLOCK_ERROR_ACTION_REPORT && s->ret >= 0) { |
bd48bde8 PB |
145 | s->ret = ret; |
146 | } | |
147 | } | |
148 | mirror_iteration_done(op, ret); | |
b9e413dd | 149 | aio_context_release(blk_get_aio_context(s->common.blk)); |
bd48bde8 PB |
150 | } |
151 | ||
152 | static void mirror_read_complete(void *opaque, int ret) | |
153 | { | |
154 | MirrorOp *op = opaque; | |
155 | MirrorBlockJob *s = op->s; | |
b9e413dd PB |
156 | |
157 | aio_context_acquire(blk_get_aio_context(s->common.blk)); | |
bd48bde8 | 158 | if (ret < 0) { |
bd48bde8 PB |
159 | BlockErrorAction action; |
160 | ||
e0d7f73e | 161 | bdrv_set_dirty_bitmap(s->dirty_bitmap, op->offset, op->bytes); |
bd48bde8 | 162 | action = mirror_error_action(s, true, -ret); |
a589569f | 163 | if (action == BLOCK_ERROR_ACTION_REPORT && s->ret >= 0) { |
bd48bde8 PB |
164 | s->ret = ret; |
165 | } | |
166 | ||
167 | mirror_iteration_done(op, ret); | |
b9e413dd | 168 | } else { |
b436982f | 169 | blk_aio_pwritev(s->target, op->offset, &op->qiov, |
b9e413dd | 170 | 0, mirror_write_complete, op); |
bd48bde8 | 171 | } |
b9e413dd | 172 | aio_context_release(blk_get_aio_context(s->common.blk)); |
bd48bde8 PB |
173 | } |
174 | ||
782d97ef EB |
175 | /* Clip bytes relative to offset to not exceed end-of-file */ |
176 | static inline int64_t mirror_clip_bytes(MirrorBlockJob *s, | |
177 | int64_t offset, | |
178 | int64_t bytes) | |
179 | { | |
180 | return MIN(bytes, s->bdev_length - offset); | |
181 | } | |
182 | ||
782d97ef EB |
183 | /* Round offset and/or bytes to target cluster if COW is needed, and |
184 | * return the offset of the adjusted tail against original. */ | |
185 | static int mirror_cow_align(MirrorBlockJob *s, int64_t *offset, | |
ae4cc877 | 186 | uint64_t *bytes) |
893f7eba | 187 | { |
e5b43573 FZ |
188 | bool need_cow; |
189 | int ret = 0; | |
782d97ef | 190 | int64_t align_offset = *offset; |
7cfd5275 | 191 | int64_t align_bytes = *bytes; |
782d97ef | 192 | int max_bytes = s->granularity * s->max_iov; |
e5b43573 | 193 | |
782d97ef EB |
194 | need_cow = !test_bit(*offset / s->granularity, s->cow_bitmap); |
195 | need_cow |= !test_bit((*offset + *bytes - 1) / s->granularity, | |
e5b43573 FZ |
196 | s->cow_bitmap); |
197 | if (need_cow) { | |
782d97ef EB |
198 | bdrv_round_to_clusters(blk_bs(s->target), *offset, *bytes, |
199 | &align_offset, &align_bytes); | |
e5b43573 | 200 | } |
3515727f | 201 | |
782d97ef EB |
202 | if (align_bytes > max_bytes) { |
203 | align_bytes = max_bytes; | |
e5b43573 | 204 | if (need_cow) { |
782d97ef | 205 | align_bytes = QEMU_ALIGN_DOWN(align_bytes, s->target_cluster_size); |
e5b43573 | 206 | } |
8f0720ec | 207 | } |
782d97ef | 208 | /* Clipping may result in align_bytes unaligned to chunk boundary, but |
4150ae60 | 209 | * that doesn't matter because it's already the end of source image. */ |
782d97ef | 210 | align_bytes = mirror_clip_bytes(s, align_offset, align_bytes); |
8f0720ec | 211 | |
782d97ef EB |
212 | ret = align_offset + align_bytes - (*offset + *bytes); |
213 | *offset = align_offset; | |
214 | *bytes = align_bytes; | |
e5b43573 FZ |
215 | assert(ret >= 0); |
216 | return ret; | |
217 | } | |
218 | ||
21cd917f FZ |
219 | static inline void mirror_wait_for_io(MirrorBlockJob *s) |
220 | { | |
221 | assert(!s->waiting_for_io); | |
222 | s->waiting_for_io = true; | |
223 | qemu_coroutine_yield(); | |
224 | s->waiting_for_io = false; | |
225 | } | |
226 | ||
e5b43573 | 227 | /* Submit async read while handling COW. |
ae4cc877 EB |
228 | * Returns: The number of bytes copied after and including offset, |
229 | * excluding any bytes copied prior to offset due to alignment. | |
230 | * This will be @bytes if no alignment is necessary, or | |
231 | * (new_end - offset) if tail is rounded up or down due to | |
e5b43573 FZ |
232 | * alignment or buffer limit. |
233 | */ | |
ae4cc877 EB |
234 | static uint64_t mirror_do_read(MirrorBlockJob *s, int64_t offset, |
235 | uint64_t bytes) | |
e5b43573 | 236 | { |
e253f4b8 | 237 | BlockBackend *source = s->common.blk; |
ae4cc877 EB |
238 | int nb_chunks; |
239 | uint64_t ret; | |
e5b43573 | 240 | MirrorOp *op; |
ae4cc877 | 241 | uint64_t max_bytes; |
e5b43573 | 242 | |
ae4cc877 | 243 | max_bytes = s->granularity * s->max_iov; |
402a4741 | 244 | |
e5b43573 | 245 | /* We can only handle as much as buf_size at a time. */ |
ae4cc877 EB |
246 | bytes = MIN(s->buf_size, MIN(max_bytes, bytes)); |
247 | assert(bytes); | |
248 | assert(bytes < BDRV_REQUEST_MAX_BYTES); | |
249 | ret = bytes; | |
402a4741 | 250 | |
e5b43573 | 251 | if (s->cow_bitmap) { |
ae4cc877 | 252 | ret += mirror_cow_align(s, &offset, &bytes); |
e5b43573 | 253 | } |
ae4cc877 EB |
254 | assert(bytes <= s->buf_size); |
255 | /* The offset is granularity-aligned because: | |
e5b43573 FZ |
256 | * 1) Caller passes in aligned values; |
257 | * 2) mirror_cow_align is used only when target cluster is larger. */ | |
ae4cc877 EB |
258 | assert(QEMU_IS_ALIGNED(offset, s->granularity)); |
259 | /* The range is sector-aligned, since bdrv_getlength() rounds up. */ | |
260 | assert(QEMU_IS_ALIGNED(bytes, BDRV_SECTOR_SIZE)); | |
261 | nb_chunks = DIV_ROUND_UP(bytes, s->granularity); | |
e5b43573 FZ |
262 | |
263 | while (s->buf_free_count < nb_chunks) { | |
ae4cc877 | 264 | trace_mirror_yield_in_flight(s, offset, s->in_flight); |
21cd917f | 265 | mirror_wait_for_io(s); |
b812f671 PB |
266 | } |
267 | ||
bd48bde8 | 268 | /* Allocate a MirrorOp that is used as an AIO callback. */ |
c84b3192 | 269 | op = g_new(MirrorOp, 1); |
bd48bde8 | 270 | op->s = s; |
ae4cc877 EB |
271 | op->offset = offset; |
272 | op->bytes = bytes; | |
402a4741 PB |
273 | |
274 | /* Now make a QEMUIOVector taking enough granularity-sized chunks | |
275 | * from s->buf_free. | |
276 | */ | |
277 | qemu_iovec_init(&op->qiov, nb_chunks); | |
402a4741 PB |
278 | while (nb_chunks-- > 0) { |
279 | MirrorBuffer *buf = QSIMPLEQ_FIRST(&s->buf_free); | |
ae4cc877 | 280 | size_t remaining = bytes - op->qiov.size; |
5a0f6fd5 | 281 | |
402a4741 PB |
282 | QSIMPLEQ_REMOVE_HEAD(&s->buf_free, next); |
283 | s->buf_free_count--; | |
5a0f6fd5 | 284 | qemu_iovec_add(&op->qiov, buf, MIN(s->granularity, remaining)); |
402a4741 | 285 | } |
bd48bde8 | 286 | |
893f7eba | 287 | /* Copy the dirty cluster. */ |
bd48bde8 | 288 | s->in_flight++; |
ae4cc877 EB |
289 | s->bytes_in_flight += bytes; |
290 | trace_mirror_one_iteration(s, offset, bytes); | |
dcfb3beb | 291 | |
ae4cc877 | 292 | blk_aio_preadv(source, offset, &op->qiov, 0, mirror_read_complete, op); |
e5b43573 FZ |
293 | return ret; |
294 | } | |
295 | ||
296 | static void mirror_do_zero_or_discard(MirrorBlockJob *s, | |
e6f24193 EB |
297 | int64_t offset, |
298 | uint64_t bytes, | |
e5b43573 FZ |
299 | bool is_discard) |
300 | { | |
301 | MirrorOp *op; | |
302 | ||
303 | /* Allocate a MirrorOp that is used as an AIO callback. The qiov is zeroed | |
304 | * so the freeing in mirror_iteration_done is nop. */ | |
305 | op = g_new0(MirrorOp, 1); | |
306 | op->s = s; | |
e6f24193 EB |
307 | op->offset = offset; |
308 | op->bytes = bytes; | |
e5b43573 FZ |
309 | |
310 | s->in_flight++; | |
e6f24193 | 311 | s->bytes_in_flight += bytes; |
e5b43573 | 312 | if (is_discard) { |
e6f24193 | 313 | blk_aio_pdiscard(s->target, offset, |
b436982f | 314 | op->bytes, mirror_write_complete, op); |
e5b43573 | 315 | } else { |
e6f24193 | 316 | blk_aio_pwrite_zeroes(s->target, offset, |
b436982f | 317 | op->bytes, s->unmap ? BDRV_REQ_MAY_UNMAP : 0, |
dcfb3beb | 318 | mirror_write_complete, op); |
e5b43573 FZ |
319 | } |
320 | } | |
321 | ||
322 | static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) | |
323 | { | |
4ef85a9c | 324 | BlockDriverState *source = s->source; |
fb2ef791 | 325 | int64_t offset, first_chunk; |
e5b43573 FZ |
326 | uint64_t delay_ns = 0; |
327 | /* At least the first dirty chunk is mirrored in one iteration. */ | |
328 | int nb_chunks = 1; | |
4b5004d9 | 329 | bool write_zeroes_ok = bdrv_can_write_zeroes_with_unmap(blk_bs(s->target)); |
b436982f | 330 | int max_io_bytes = MAX(s->buf_size / MAX_IN_FLIGHT, MAX_IO_BYTES); |
e5b43573 | 331 | |
b64bd51e | 332 | bdrv_dirty_bitmap_lock(s->dirty_bitmap); |
f798184c | 333 | offset = bdrv_dirty_iter_next(s->dbi); |
fb2ef791 | 334 | if (offset < 0) { |
dc162c8e | 335 | bdrv_set_dirty_iter(s->dbi, 0); |
f798184c | 336 | offset = bdrv_dirty_iter_next(s->dbi); |
9a46dba7 | 337 | trace_mirror_restart_iter(s, bdrv_get_dirty_count(s->dirty_bitmap)); |
fb2ef791 | 338 | assert(offset >= 0); |
e5b43573 | 339 | } |
b64bd51e | 340 | bdrv_dirty_bitmap_unlock(s->dirty_bitmap); |
e5b43573 | 341 | |
fb2ef791 | 342 | first_chunk = offset / s->granularity; |
9c83625b | 343 | while (test_bit(first_chunk, s->in_flight_bitmap)) { |
fb2ef791 | 344 | trace_mirror_yield_in_flight(s, offset, s->in_flight); |
9c83625b HR |
345 | mirror_wait_for_io(s); |
346 | } | |
347 | ||
da01ff7f | 348 | job_pause_point(&s->common.job); |
565ac01f | 349 | |
e5b43573 FZ |
350 | /* Find the number of consective dirty chunks following the first dirty |
351 | * one, and wait for in flight requests in them. */ | |
b64bd51e | 352 | bdrv_dirty_bitmap_lock(s->dirty_bitmap); |
fb2ef791 | 353 | while (nb_chunks * s->granularity < s->buf_size) { |
dc162c8e | 354 | int64_t next_dirty; |
fb2ef791 EB |
355 | int64_t next_offset = offset + nb_chunks * s->granularity; |
356 | int64_t next_chunk = next_offset / s->granularity; | |
357 | if (next_offset >= s->bdev_length || | |
3b5d4df0 | 358 | !bdrv_get_dirty_locked(source, s->dirty_bitmap, next_offset)) { |
e5b43573 FZ |
359 | break; |
360 | } | |
361 | if (test_bit(next_chunk, s->in_flight_bitmap)) { | |
9c83625b | 362 | break; |
e5b43573 | 363 | } |
9c83625b | 364 | |
f798184c | 365 | next_dirty = bdrv_dirty_iter_next(s->dbi); |
fb2ef791 | 366 | if (next_dirty > next_offset || next_dirty < 0) { |
f27a2742 | 367 | /* The bitmap iterator's cache is stale, refresh it */ |
715a74d8 | 368 | bdrv_set_dirty_iter(s->dbi, next_offset); |
f798184c | 369 | next_dirty = bdrv_dirty_iter_next(s->dbi); |
f27a2742 | 370 | } |
fb2ef791 | 371 | assert(next_dirty == next_offset); |
9c83625b | 372 | nb_chunks++; |
e5b43573 FZ |
373 | } |
374 | ||
375 | /* Clear dirty bits before querying the block status, because | |
31826642 | 376 | * calling bdrv_block_status_above could yield - if some blocks are |
e5b43573 FZ |
377 | * marked dirty in this window, we need to know. |
378 | */ | |
e0d7f73e EB |
379 | bdrv_reset_dirty_bitmap_locked(s->dirty_bitmap, offset, |
380 | nb_chunks * s->granularity); | |
b64bd51e PB |
381 | bdrv_dirty_bitmap_unlock(s->dirty_bitmap); |
382 | ||
fb2ef791 EB |
383 | bitmap_set(s->in_flight_bitmap, offset / s->granularity, nb_chunks); |
384 | while (nb_chunks > 0 && offset < s->bdev_length) { | |
31826642 | 385 | int ret; |
7cfd5275 | 386 | int64_t io_bytes; |
f3e4ce4a | 387 | int64_t io_bytes_acct; |
e5b43573 FZ |
388 | enum MirrorMethod { |
389 | MIRROR_METHOD_COPY, | |
390 | MIRROR_METHOD_ZERO, | |
391 | MIRROR_METHOD_DISCARD | |
392 | } mirror_method = MIRROR_METHOD_COPY; | |
393 | ||
fb2ef791 | 394 | assert(!(offset % s->granularity)); |
31826642 EB |
395 | ret = bdrv_block_status_above(source, NULL, offset, |
396 | nb_chunks * s->granularity, | |
397 | &io_bytes, NULL, NULL); | |
e5b43573 | 398 | if (ret < 0) { |
fb2ef791 | 399 | io_bytes = MIN(nb_chunks * s->granularity, max_io_bytes); |
0965a41e | 400 | } else if (ret & BDRV_BLOCK_DATA) { |
fb2ef791 | 401 | io_bytes = MIN(io_bytes, max_io_bytes); |
e5b43573 FZ |
402 | } |
403 | ||
fb2ef791 EB |
404 | io_bytes -= io_bytes % s->granularity; |
405 | if (io_bytes < s->granularity) { | |
406 | io_bytes = s->granularity; | |
e5b43573 | 407 | } else if (ret >= 0 && !(ret & BDRV_BLOCK_DATA)) { |
fb2ef791 | 408 | int64_t target_offset; |
7cfd5275 | 409 | int64_t target_bytes; |
fb2ef791 EB |
410 | bdrv_round_to_clusters(blk_bs(s->target), offset, io_bytes, |
411 | &target_offset, &target_bytes); | |
412 | if (target_offset == offset && | |
413 | target_bytes == io_bytes) { | |
e5b43573 FZ |
414 | mirror_method = ret & BDRV_BLOCK_ZERO ? |
415 | MIRROR_METHOD_ZERO : | |
416 | MIRROR_METHOD_DISCARD; | |
417 | } | |
418 | } | |
419 | ||
cf56a3c6 | 420 | while (s->in_flight >= MAX_IN_FLIGHT) { |
fb2ef791 | 421 | trace_mirror_yield_in_flight(s, offset, s->in_flight); |
cf56a3c6 DL |
422 | mirror_wait_for_io(s); |
423 | } | |
424 | ||
dbaa7b57 VSO |
425 | if (s->ret < 0) { |
426 | return 0; | |
427 | } | |
428 | ||
fb2ef791 | 429 | io_bytes = mirror_clip_bytes(s, offset, io_bytes); |
e5b43573 FZ |
430 | switch (mirror_method) { |
431 | case MIRROR_METHOD_COPY: | |
fb2ef791 | 432 | io_bytes = io_bytes_acct = mirror_do_read(s, offset, io_bytes); |
e5b43573 FZ |
433 | break; |
434 | case MIRROR_METHOD_ZERO: | |
e5b43573 | 435 | case MIRROR_METHOD_DISCARD: |
fb2ef791 | 436 | mirror_do_zero_or_discard(s, offset, io_bytes, |
4b5004d9 DL |
437 | mirror_method == MIRROR_METHOD_DISCARD); |
438 | if (write_zeroes_ok) { | |
f3e4ce4a | 439 | io_bytes_acct = 0; |
4b5004d9 | 440 | } else { |
fb2ef791 | 441 | io_bytes_acct = io_bytes; |
4b5004d9 | 442 | } |
e5b43573 FZ |
443 | break; |
444 | default: | |
445 | abort(); | |
446 | } | |
fb2ef791 EB |
447 | assert(io_bytes); |
448 | offset += io_bytes; | |
449 | nb_chunks -= DIV_ROUND_UP(io_bytes, s->granularity); | |
dee81d51 | 450 | delay_ns = block_job_ratelimit_get_delay(&s->common, io_bytes_acct); |
dcfb3beb | 451 | } |
cc8c9d6c | 452 | return delay_ns; |
bd48bde8 | 453 | } |
b952b558 | 454 | |
402a4741 PB |
455 | static void mirror_free_init(MirrorBlockJob *s) |
456 | { | |
457 | int granularity = s->granularity; | |
458 | size_t buf_size = s->buf_size; | |
459 | uint8_t *buf = s->buf; | |
460 | ||
461 | assert(s->buf_free_count == 0); | |
462 | QSIMPLEQ_INIT(&s->buf_free); | |
463 | while (buf_size != 0) { | |
464 | MirrorBuffer *cur = (MirrorBuffer *)buf; | |
465 | QSIMPLEQ_INSERT_TAIL(&s->buf_free, cur, next); | |
466 | s->buf_free_count++; | |
467 | buf_size -= granularity; | |
468 | buf += granularity; | |
469 | } | |
470 | } | |
471 | ||
bae8196d PB |
472 | /* This is also used for the .pause callback. There is no matching |
473 | * mirror_resume() because mirror_run() will begin iterating again | |
474 | * when the job is resumed. | |
475 | */ | |
476 | static void mirror_wait_for_all_io(MirrorBlockJob *s) | |
bd48bde8 PB |
477 | { |
478 | while (s->in_flight > 0) { | |
21cd917f | 479 | mirror_wait_for_io(s); |
bd48bde8 | 480 | } |
893f7eba PB |
481 | } |
482 | ||
5a7e7a0b SH |
483 | typedef struct { |
484 | int ret; | |
485 | } MirrorExitData; | |
486 | ||
1908a559 | 487 | static void mirror_exit(Job *job, void *opaque) |
5a7e7a0b | 488 | { |
1908a559 KW |
489 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common.job); |
490 | BlockJob *bjob = &s->common; | |
5a7e7a0b SH |
491 | MirrorExitData *data = opaque; |
492 | AioContext *replace_aio_context = NULL; | |
4ef85a9c | 493 | BlockDriverState *src = s->source; |
e253f4b8 | 494 | BlockDriverState *target_bs = blk_bs(s->target); |
4ef85a9c | 495 | BlockDriverState *mirror_top_bs = s->mirror_top_bs; |
12fa4af6 | 496 | Error *local_err = NULL; |
3f09bfbc | 497 | |
2119882c PB |
498 | bdrv_release_dirty_bitmap(src, s->dirty_bitmap); |
499 | ||
3f09bfbc | 500 | /* Make sure that the source BDS doesn't go away before we called |
3d70ff53 | 501 | * job_completed(). */ |
3f09bfbc | 502 | bdrv_ref(src); |
4ef85a9c | 503 | bdrv_ref(mirror_top_bs); |
7d9fcb39 KW |
504 | bdrv_ref(target_bs); |
505 | ||
506 | /* Remove target parent that still uses BLK_PERM_WRITE/RESIZE before | |
507 | * inserting target_bs at s->to_replace, where we might not be able to get | |
63c8ef28 KW |
508 | * these permissions. |
509 | * | |
510 | * Note that blk_unref() alone doesn't necessarily drop permissions because | |
511 | * we might be running nested inside mirror_drain(), which takes an extra | |
512 | * reference, so use an explicit blk_set_perm() first. */ | |
513 | blk_set_perm(s->target, 0, BLK_PERM_ALL, &error_abort); | |
7d9fcb39 KW |
514 | blk_unref(s->target); |
515 | s->target = NULL; | |
4ef85a9c KW |
516 | |
517 | /* We don't access the source any more. Dropping any WRITE/RESIZE is | |
518 | * required before it could become a backing file of target_bs. */ | |
519 | bdrv_child_try_set_perm(mirror_top_bs->backing, 0, BLK_PERM_ALL, | |
520 | &error_abort); | |
521 | if (s->backing_mode == MIRROR_SOURCE_BACKING_CHAIN) { | |
522 | BlockDriverState *backing = s->is_none_mode ? src : s->base; | |
523 | if (backing_bs(target_bs) != backing) { | |
12fa4af6 KW |
524 | bdrv_set_backing_hd(target_bs, backing, &local_err); |
525 | if (local_err) { | |
526 | error_report_err(local_err); | |
527 | data->ret = -EPERM; | |
528 | } | |
4ef85a9c KW |
529 | } |
530 | } | |
5a7e7a0b SH |
531 | |
532 | if (s->to_replace) { | |
533 | replace_aio_context = bdrv_get_aio_context(s->to_replace); | |
534 | aio_context_acquire(replace_aio_context); | |
535 | } | |
536 | ||
537 | if (s->should_complete && data->ret == 0) { | |
e253f4b8 | 538 | BlockDriverState *to_replace = src; |
5a7e7a0b SH |
539 | if (s->to_replace) { |
540 | to_replace = s->to_replace; | |
541 | } | |
40365552 | 542 | |
e253f4b8 KW |
543 | if (bdrv_get_flags(target_bs) != bdrv_get_flags(to_replace)) { |
544 | bdrv_reopen(target_bs, bdrv_get_flags(to_replace), NULL); | |
5a7e7a0b | 545 | } |
b8804815 KW |
546 | |
547 | /* The mirror job has no requests in flight any more, but we need to | |
548 | * drain potential other users of the BDS before changing the graph. */ | |
e253f4b8 | 549 | bdrv_drained_begin(target_bs); |
5fe31c25 | 550 | bdrv_replace_node(to_replace, target_bs, &local_err); |
e253f4b8 | 551 | bdrv_drained_end(target_bs); |
5fe31c25 KW |
552 | if (local_err) { |
553 | error_report_err(local_err); | |
554 | data->ret = -EPERM; | |
555 | } | |
5a7e7a0b SH |
556 | } |
557 | if (s->to_replace) { | |
558 | bdrv_op_unblock_all(s->to_replace, s->replace_blocker); | |
559 | error_free(s->replace_blocker); | |
560 | bdrv_unref(s->to_replace); | |
561 | } | |
562 | if (replace_aio_context) { | |
563 | aio_context_release(replace_aio_context); | |
564 | } | |
565 | g_free(s->replaces); | |
7d9fcb39 | 566 | bdrv_unref(target_bs); |
4ef85a9c KW |
567 | |
568 | /* Remove the mirror filter driver from the graph. Before this, get rid of | |
569 | * the blockers on the intermediate nodes so that the resulting state is | |
0bf74767 KW |
570 | * valid. Also give up permissions on mirror_top_bs->backing, which might |
571 | * block the removal. */ | |
1908a559 | 572 | block_job_remove_all_bdrv(bjob); |
c1cef672 FZ |
573 | bdrv_child_try_set_perm(mirror_top_bs->backing, 0, BLK_PERM_ALL, |
574 | &error_abort); | |
5fe31c25 | 575 | bdrv_replace_node(mirror_top_bs, backing_bs(mirror_top_bs), &error_abort); |
4ef85a9c KW |
576 | |
577 | /* We just changed the BDS the job BB refers to (with either or both of the | |
5fe31c25 KW |
578 | * bdrv_replace_node() calls), so switch the BB back so the cleanup does |
579 | * the right thing. We don't need any permissions any more now. */ | |
1908a559 KW |
580 | blk_remove_bs(bjob->blk); |
581 | blk_set_perm(bjob->blk, 0, BLK_PERM_ALL, &error_abort); | |
582 | blk_insert_bs(bjob->blk, mirror_top_bs, &error_abort); | |
4ef85a9c | 583 | |
1266c9b9 | 584 | job_completed(job, data->ret, NULL); |
4ef85a9c | 585 | |
5a7e7a0b | 586 | g_free(data); |
176c3699 | 587 | bdrv_drained_end(src); |
4ef85a9c | 588 | bdrv_unref(mirror_top_bs); |
3f09bfbc | 589 | bdrv_unref(src); |
5a7e7a0b SH |
590 | } |
591 | ||
49efb1f5 DL |
592 | static void mirror_throttle(MirrorBlockJob *s) |
593 | { | |
594 | int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); | |
595 | ||
18bb6928 | 596 | if (now - s->last_pause_ns > BLOCK_JOB_SLICE_TIME) { |
49efb1f5 | 597 | s->last_pause_ns = now; |
5d43e86e | 598 | job_sleep_ns(&s->common.job, 0); |
49efb1f5 | 599 | } else { |
da01ff7f | 600 | job_pause_point(&s->common.job); |
49efb1f5 DL |
601 | } |
602 | } | |
603 | ||
c0b363ad DL |
604 | static int coroutine_fn mirror_dirty_init(MirrorBlockJob *s) |
605 | { | |
23ca459a | 606 | int64_t offset; |
c0b363ad | 607 | BlockDriverState *base = s->base; |
4ef85a9c | 608 | BlockDriverState *bs = s->source; |
c0b363ad | 609 | BlockDriverState *target_bs = blk_bs(s->target); |
23ca459a | 610 | int ret; |
51b0a488 | 611 | int64_t count; |
c0b363ad | 612 | |
b7d5062c | 613 | if (base == NULL && !bdrv_has_zero_init(target_bs)) { |
c7c2769c | 614 | if (!bdrv_can_write_zeroes_with_unmap(target_bs)) { |
e0d7f73e | 615 | bdrv_set_dirty_bitmap(s->dirty_bitmap, 0, s->bdev_length); |
c7c2769c DL |
616 | return 0; |
617 | } | |
618 | ||
90ab48eb | 619 | s->initial_zeroing_ongoing = true; |
23ca459a EB |
620 | for (offset = 0; offset < s->bdev_length; ) { |
621 | int bytes = MIN(s->bdev_length - offset, | |
622 | QEMU_ALIGN_DOWN(INT_MAX, s->granularity)); | |
c7c2769c DL |
623 | |
624 | mirror_throttle(s); | |
625 | ||
daa7f2f9 | 626 | if (job_is_cancelled(&s->common.job)) { |
90ab48eb | 627 | s->initial_zeroing_ongoing = false; |
c7c2769c DL |
628 | return 0; |
629 | } | |
630 | ||
631 | if (s->in_flight >= MAX_IN_FLIGHT) { | |
67adf4b3 EB |
632 | trace_mirror_yield(s, UINT64_MAX, s->buf_free_count, |
633 | s->in_flight); | |
c7c2769c DL |
634 | mirror_wait_for_io(s); |
635 | continue; | |
636 | } | |
637 | ||
23ca459a EB |
638 | mirror_do_zero_or_discard(s, offset, bytes, false); |
639 | offset += bytes; | |
c7c2769c DL |
640 | } |
641 | ||
bae8196d | 642 | mirror_wait_for_all_io(s); |
90ab48eb | 643 | s->initial_zeroing_ongoing = false; |
b7d5062c DL |
644 | } |
645 | ||
c0b363ad | 646 | /* First part, loop on the sectors and initialize the dirty bitmap. */ |
23ca459a | 647 | for (offset = 0; offset < s->bdev_length; ) { |
c0b363ad | 648 | /* Just to make sure we are not exceeding int limit. */ |
23ca459a EB |
649 | int bytes = MIN(s->bdev_length - offset, |
650 | QEMU_ALIGN_DOWN(INT_MAX, s->granularity)); | |
c0b363ad DL |
651 | |
652 | mirror_throttle(s); | |
653 | ||
daa7f2f9 | 654 | if (job_is_cancelled(&s->common.job)) { |
c0b363ad DL |
655 | return 0; |
656 | } | |
657 | ||
23ca459a | 658 | ret = bdrv_is_allocated_above(bs, base, offset, bytes, &count); |
c0b363ad DL |
659 | if (ret < 0) { |
660 | return ret; | |
661 | } | |
662 | ||
23ca459a | 663 | assert(count); |
b7d5062c | 664 | if (ret == 1) { |
23ca459a | 665 | bdrv_set_dirty_bitmap(s->dirty_bitmap, offset, count); |
c0b363ad | 666 | } |
23ca459a | 667 | offset += count; |
c0b363ad DL |
668 | } |
669 | return 0; | |
670 | } | |
671 | ||
bdffb31d PB |
672 | /* Called when going out of the streaming phase to flush the bulk of the |
673 | * data to the medium, or just before completing. | |
674 | */ | |
675 | static int mirror_flush(MirrorBlockJob *s) | |
676 | { | |
677 | int ret = blk_flush(s->target); | |
678 | if (ret < 0) { | |
679 | if (mirror_error_action(s, false, -ret) == BLOCK_ERROR_ACTION_REPORT) { | |
680 | s->ret = ret; | |
681 | } | |
682 | } | |
683 | return ret; | |
684 | } | |
685 | ||
893f7eba PB |
686 | static void coroutine_fn mirror_run(void *opaque) |
687 | { | |
688 | MirrorBlockJob *s = opaque; | |
5a7e7a0b | 689 | MirrorExitData *data; |
4ef85a9c | 690 | BlockDriverState *bs = s->source; |
e253f4b8 | 691 | BlockDriverState *target_bs = blk_bs(s->target); |
9a0cec66 | 692 | bool need_drain = true; |
c0b363ad | 693 | int64_t length; |
b812f671 | 694 | BlockDriverInfo bdi; |
1d33936e JC |
695 | char backing_filename[2]; /* we only need 2 characters because we are only |
696 | checking for a NULL string */ | |
893f7eba | 697 | int ret = 0; |
893f7eba | 698 | |
daa7f2f9 | 699 | if (job_is_cancelled(&s->common.job)) { |
893f7eba PB |
700 | goto immediate_exit; |
701 | } | |
702 | ||
b21c7652 HR |
703 | s->bdev_length = bdrv_getlength(bs); |
704 | if (s->bdev_length < 0) { | |
705 | ret = s->bdev_length; | |
373df5b1 | 706 | goto immediate_exit; |
becc347e KW |
707 | } |
708 | ||
709 | /* Active commit must resize the base image if its size differs from the | |
710 | * active layer. */ | |
711 | if (s->base == blk_bs(s->target)) { | |
712 | int64_t base_length; | |
713 | ||
714 | base_length = blk_getlength(s->target); | |
715 | if (base_length < 0) { | |
716 | ret = base_length; | |
717 | goto immediate_exit; | |
718 | } | |
719 | ||
720 | if (s->bdev_length > base_length) { | |
3a691c50 HR |
721 | ret = blk_truncate(s->target, s->bdev_length, PREALLOC_MODE_OFF, |
722 | NULL); | |
becc347e KW |
723 | if (ret < 0) { |
724 | goto immediate_exit; | |
725 | } | |
726 | } | |
727 | } | |
728 | ||
729 | if (s->bdev_length == 0) { | |
2e1795b5 KW |
730 | /* Transition to the READY state and wait for complete. */ |
731 | job_transition_to_ready(&s->common.job); | |
9e48b025 | 732 | s->synced = true; |
daa7f2f9 | 733 | while (!job_is_cancelled(&s->common.job) && !s->should_complete) { |
198c49cc | 734 | job_yield(&s->common.job); |
9e48b025 | 735 | } |
daa7f2f9 | 736 | s->common.job.cancelled = false; |
9e48b025 | 737 | goto immediate_exit; |
893f7eba PB |
738 | } |
739 | ||
b21c7652 | 740 | length = DIV_ROUND_UP(s->bdev_length, s->granularity); |
402a4741 PB |
741 | s->in_flight_bitmap = bitmap_new(length); |
742 | ||
b812f671 PB |
743 | /* If we have no backing file yet in the destination, we cannot let |
744 | * the destination do COW. Instead, we copy sectors around the | |
745 | * dirty data if needed. We need a bitmap to do that. | |
746 | */ | |
e253f4b8 | 747 | bdrv_get_backing_filename(target_bs, backing_filename, |
b812f671 | 748 | sizeof(backing_filename)); |
e253f4b8 | 749 | if (!bdrv_get_info(target_bs, &bdi) && bdi.cluster_size) { |
b436982f EB |
750 | s->target_cluster_size = bdi.cluster_size; |
751 | } else { | |
752 | s->target_cluster_size = BDRV_SECTOR_SIZE; | |
e5b43573 | 753 | } |
b436982f EB |
754 | if (backing_filename[0] && !target_bs->backing && |
755 | s->granularity < s->target_cluster_size) { | |
756 | s->buf_size = MAX(s->buf_size, s->target_cluster_size); | |
e5b43573 | 757 | s->cow_bitmap = bitmap_new(length); |
b812f671 | 758 | } |
e253f4b8 | 759 | s->max_iov = MIN(bs->bl.max_iov, target_bs->bl.max_iov); |
b812f671 | 760 | |
7504edf4 KW |
761 | s->buf = qemu_try_blockalign(bs, s->buf_size); |
762 | if (s->buf == NULL) { | |
763 | ret = -ENOMEM; | |
764 | goto immediate_exit; | |
765 | } | |
766 | ||
402a4741 | 767 | mirror_free_init(s); |
893f7eba | 768 | |
49efb1f5 | 769 | s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); |
03544a6e | 770 | if (!s->is_none_mode) { |
c0b363ad | 771 | ret = mirror_dirty_init(s); |
daa7f2f9 | 772 | if (ret < 0 || job_is_cancelled(&s->common.job)) { |
c0b363ad | 773 | goto immediate_exit; |
893f7eba PB |
774 | } |
775 | } | |
776 | ||
dc162c8e | 777 | assert(!s->dbi); |
715a74d8 | 778 | s->dbi = bdrv_dirty_iter_new(s->dirty_bitmap); |
893f7eba | 779 | for (;;) { |
cc8c9d6c | 780 | uint64_t delay_ns = 0; |
49efb1f5 | 781 | int64_t cnt, delta; |
893f7eba PB |
782 | bool should_complete; |
783 | ||
bd48bde8 PB |
784 | if (s->ret < 0) { |
785 | ret = s->ret; | |
786 | goto immediate_exit; | |
787 | } | |
788 | ||
da01ff7f | 789 | job_pause_point(&s->common.job); |
565ac01f | 790 | |
20dca810 | 791 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
05df8a6a KW |
792 | /* cnt is the number of dirty bytes remaining and s->bytes_in_flight is |
793 | * the number of bytes currently being processed; together those are | |
794 | * the current remaining operation length */ | |
30a5c887 | 795 | job_progress_set_remaining(&s->common.job, s->bytes_in_flight + cnt); |
bd48bde8 PB |
796 | |
797 | /* Note that even when no rate limit is applied we need to yield | |
a7282330 | 798 | * periodically with no pending I/O so that bdrv_drain_all() returns. |
18bb6928 KW |
799 | * We do so every BLKOCK_JOB_SLICE_TIME nanoseconds, or when there is |
800 | * an error, or when the source is clean, whichever comes first. */ | |
49efb1f5 | 801 | delta = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - s->last_pause_ns; |
18bb6928 | 802 | if (delta < BLOCK_JOB_SLICE_TIME && |
bd48bde8 | 803 | s->common.iostatus == BLOCK_DEVICE_IO_STATUS_OK) { |
cf56a3c6 | 804 | if (s->in_flight >= MAX_IN_FLIGHT || s->buf_free_count == 0 || |
402a4741 | 805 | (cnt == 0 && s->in_flight > 0)) { |
9a46dba7 | 806 | trace_mirror_yield(s, cnt, s->buf_free_count, s->in_flight); |
21cd917f | 807 | mirror_wait_for_io(s); |
bd48bde8 PB |
808 | continue; |
809 | } else if (cnt != 0) { | |
cc8c9d6c | 810 | delay_ns = mirror_iteration(s); |
893f7eba | 811 | } |
893f7eba PB |
812 | } |
813 | ||
814 | should_complete = false; | |
bd48bde8 | 815 | if (s->in_flight == 0 && cnt == 0) { |
893f7eba | 816 | trace_mirror_before_flush(s); |
bdffb31d PB |
817 | if (!s->synced) { |
818 | if (mirror_flush(s) < 0) { | |
819 | /* Go check s->ret. */ | |
820 | continue; | |
b952b558 | 821 | } |
b952b558 PB |
822 | /* We're out of the streaming phase. From now on, if the job |
823 | * is cancelled we will actually complete all pending I/O and | |
824 | * report completion. This way, block-job-cancel will leave | |
825 | * the target in a consistent state. | |
826 | */ | |
2e1795b5 | 827 | job_transition_to_ready(&s->common.job); |
bdffb31d | 828 | s->synced = true; |
d63ffd87 | 829 | } |
bdffb31d PB |
830 | |
831 | should_complete = s->should_complete || | |
daa7f2f9 | 832 | job_is_cancelled(&s->common.job); |
bdffb31d | 833 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
893f7eba PB |
834 | } |
835 | ||
836 | if (cnt == 0 && should_complete) { | |
837 | /* The dirty bitmap is not updated while operations are pending. | |
838 | * If we're about to exit, wait for pending operations before | |
839 | * calling bdrv_get_dirty_count(bs), or we may exit while the | |
840 | * source has dirty data to copy! | |
841 | * | |
842 | * Note that I/O can be submitted by the guest while | |
9a0cec66 PB |
843 | * mirror_populate runs, so pause it now. Before deciding |
844 | * whether to switch to target check one last time if I/O has | |
845 | * come in the meanwhile, and if not flush the data to disk. | |
893f7eba | 846 | */ |
9a46dba7 | 847 | trace_mirror_before_drain(s, cnt); |
9a0cec66 PB |
848 | |
849 | bdrv_drained_begin(bs); | |
20dca810 | 850 | cnt = bdrv_get_dirty_count(s->dirty_bitmap); |
bdffb31d | 851 | if (cnt > 0 || mirror_flush(s) < 0) { |
9a0cec66 PB |
852 | bdrv_drained_end(bs); |
853 | continue; | |
854 | } | |
855 | ||
856 | /* The two disks are in sync. Exit and report successful | |
857 | * completion. | |
858 | */ | |
859 | assert(QLIST_EMPTY(&bs->tracked_requests)); | |
daa7f2f9 | 860 | s->common.job.cancelled = false; |
9a0cec66 PB |
861 | need_drain = false; |
862 | break; | |
893f7eba PB |
863 | } |
864 | ||
865 | ret = 0; | |
ddc4115e SH |
866 | |
867 | if (s->synced && !should_complete) { | |
18bb6928 KW |
868 | delay_ns = (s->in_flight == 0 && |
869 | cnt == 0 ? BLOCK_JOB_SLICE_TIME : 0); | |
ddc4115e | 870 | } |
9a46dba7 | 871 | trace_mirror_before_sleep(s, cnt, s->synced, delay_ns); |
5d43e86e | 872 | job_sleep_ns(&s->common.job, delay_ns); |
daa7f2f9 | 873 | if (job_is_cancelled(&s->common.job) && |
004e95df | 874 | (!s->synced || s->common.job.force_cancel)) |
eb36639f | 875 | { |
b76e4458 | 876 | break; |
893f7eba | 877 | } |
49efb1f5 | 878 | s->last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); |
893f7eba PB |
879 | } |
880 | ||
881 | immediate_exit: | |
bd48bde8 PB |
882 | if (s->in_flight > 0) { |
883 | /* We get here only if something went wrong. Either the job failed, | |
884 | * or it was cancelled prematurely so that we do not guarantee that | |
885 | * the target is a copy of the source. | |
886 | */ | |
004e95df | 887 | assert(ret < 0 || ((s->common.job.force_cancel || !s->synced) && |
daa7f2f9 | 888 | job_is_cancelled(&s->common.job))); |
9a0cec66 | 889 | assert(need_drain); |
bae8196d | 890 | mirror_wait_for_all_io(s); |
bd48bde8 PB |
891 | } |
892 | ||
893 | assert(s->in_flight == 0); | |
7191bf31 | 894 | qemu_vfree(s->buf); |
b812f671 | 895 | g_free(s->cow_bitmap); |
402a4741 | 896 | g_free(s->in_flight_bitmap); |
dc162c8e | 897 | bdrv_dirty_iter_free(s->dbi); |
5a7e7a0b SH |
898 | |
899 | data = g_malloc(sizeof(*data)); | |
900 | data->ret = ret; | |
9a0cec66 PB |
901 | |
902 | if (need_drain) { | |
903 | bdrv_drained_begin(bs); | |
904 | } | |
1908a559 | 905 | job_defer_to_main_loop(&s->common.job, mirror_exit, data); |
893f7eba PB |
906 | } |
907 | ||
3453d972 | 908 | static void mirror_complete(Job *job, Error **errp) |
d63ffd87 | 909 | { |
3453d972 | 910 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common.job); |
4ef85a9c | 911 | BlockDriverState *target; |
274fccee | 912 | |
274fccee | 913 | target = blk_bs(s->target); |
d63ffd87 | 914 | |
d63ffd87 | 915 | if (!s->synced) { |
9df229c3 | 916 | error_setg(errp, "The active block job '%s' cannot be completed", |
3453d972 | 917 | job->id); |
d63ffd87 PB |
918 | return; |
919 | } | |
920 | ||
274fccee HR |
921 | if (s->backing_mode == MIRROR_OPEN_BACKING_CHAIN) { |
922 | int ret; | |
923 | ||
924 | assert(!target->backing); | |
925 | ret = bdrv_open_backing_file(target, NULL, "backing", errp); | |
926 | if (ret < 0) { | |
927 | return; | |
928 | } | |
929 | } | |
930 | ||
15d67298 | 931 | /* block all operations on to_replace bs */ |
09158f00 | 932 | if (s->replaces) { |
5a7e7a0b SH |
933 | AioContext *replace_aio_context; |
934 | ||
e12f3784 | 935 | s->to_replace = bdrv_find_node(s->replaces); |
09158f00 | 936 | if (!s->to_replace) { |
e12f3784 | 937 | error_setg(errp, "Node name '%s' not found", s->replaces); |
09158f00 BC |
938 | return; |
939 | } | |
940 | ||
5a7e7a0b SH |
941 | replace_aio_context = bdrv_get_aio_context(s->to_replace); |
942 | aio_context_acquire(replace_aio_context); | |
943 | ||
4ef85a9c KW |
944 | /* TODO Translate this into permission system. Current definition of |
945 | * GRAPH_MOD would require to request it for the parents; they might | |
946 | * not even be BlockDriverStates, however, so a BdrvChild can't address | |
947 | * them. May need redefinition of GRAPH_MOD. */ | |
09158f00 BC |
948 | error_setg(&s->replace_blocker, |
949 | "block device is in use by block-job-complete"); | |
950 | bdrv_op_block_all(s->to_replace, s->replace_blocker); | |
951 | bdrv_ref(s->to_replace); | |
5a7e7a0b SH |
952 | |
953 | aio_context_release(replace_aio_context); | |
09158f00 BC |
954 | } |
955 | ||
d63ffd87 | 956 | s->should_complete = true; |
3d70ff53 | 957 | job_enter(job); |
d63ffd87 PB |
958 | } |
959 | ||
da01ff7f | 960 | static void mirror_pause(Job *job) |
565ac01f | 961 | { |
da01ff7f | 962 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common.job); |
565ac01f | 963 | |
bae8196d | 964 | mirror_wait_for_all_io(s); |
565ac01f SH |
965 | } |
966 | ||
967 | static void mirror_attached_aio_context(BlockJob *job, AioContext *new_context) | |
968 | { | |
969 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); | |
970 | ||
971 | blk_set_aio_context(s->target, new_context); | |
972 | } | |
973 | ||
bae8196d PB |
974 | static void mirror_drain(BlockJob *job) |
975 | { | |
976 | MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); | |
977 | ||
978 | /* Need to keep a reference in case blk_drain triggers execution | |
979 | * of mirror_complete... | |
980 | */ | |
981 | if (s->target) { | |
982 | BlockBackend *target = s->target; | |
983 | blk_ref(target); | |
984 | blk_drain(target); | |
985 | blk_unref(target); | |
986 | } | |
987 | } | |
988 | ||
3fc4b10a | 989 | static const BlockJobDriver mirror_job_driver = { |
33e9e9bd KW |
990 | .job_driver = { |
991 | .instance_size = sizeof(MirrorBlockJob), | |
252291ea | 992 | .job_type = JOB_TYPE_MIRROR, |
80fa2c75 | 993 | .free = block_job_free, |
b15de828 | 994 | .user_resume = block_job_user_resume, |
b69f777d | 995 | .drain = block_job_drain, |
da01ff7f KW |
996 | .start = mirror_run, |
997 | .pause = mirror_pause, | |
3453d972 | 998 | .complete = mirror_complete, |
33e9e9bd | 999 | }, |
565ac01f | 1000 | .attached_aio_context = mirror_attached_aio_context, |
bae8196d | 1001 | .drain = mirror_drain, |
893f7eba PB |
1002 | }; |
1003 | ||
03544a6e | 1004 | static const BlockJobDriver commit_active_job_driver = { |
33e9e9bd KW |
1005 | .job_driver = { |
1006 | .instance_size = sizeof(MirrorBlockJob), | |
252291ea | 1007 | .job_type = JOB_TYPE_COMMIT, |
80fa2c75 | 1008 | .free = block_job_free, |
b15de828 | 1009 | .user_resume = block_job_user_resume, |
b69f777d | 1010 | .drain = block_job_drain, |
da01ff7f KW |
1011 | .start = mirror_run, |
1012 | .pause = mirror_pause, | |
3453d972 | 1013 | .complete = mirror_complete, |
33e9e9bd | 1014 | }, |
565ac01f | 1015 | .attached_aio_context = mirror_attached_aio_context, |
bae8196d | 1016 | .drain = mirror_drain, |
03544a6e FZ |
1017 | }; |
1018 | ||
4ef85a9c KW |
1019 | static int coroutine_fn bdrv_mirror_top_preadv(BlockDriverState *bs, |
1020 | uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) | |
1021 | { | |
1022 | return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags); | |
1023 | } | |
1024 | ||
1025 | static int coroutine_fn bdrv_mirror_top_pwritev(BlockDriverState *bs, | |
1026 | uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) | |
1027 | { | |
1028 | return bdrv_co_pwritev(bs->backing, offset, bytes, qiov, flags); | |
1029 | } | |
1030 | ||
1031 | static int coroutine_fn bdrv_mirror_top_flush(BlockDriverState *bs) | |
1032 | { | |
ce960aa9 VSO |
1033 | if (bs->backing == NULL) { |
1034 | /* we can be here after failed bdrv_append in mirror_start_job */ | |
1035 | return 0; | |
1036 | } | |
4ef85a9c KW |
1037 | return bdrv_co_flush(bs->backing->bs); |
1038 | } | |
1039 | ||
4ef85a9c | 1040 | static int coroutine_fn bdrv_mirror_top_pwrite_zeroes(BlockDriverState *bs, |
f5a5ca79 | 1041 | int64_t offset, int bytes, BdrvRequestFlags flags) |
4ef85a9c | 1042 | { |
f5a5ca79 | 1043 | return bdrv_co_pwrite_zeroes(bs->backing, offset, bytes, flags); |
4ef85a9c KW |
1044 | } |
1045 | ||
1046 | static int coroutine_fn bdrv_mirror_top_pdiscard(BlockDriverState *bs, | |
f5a5ca79 | 1047 | int64_t offset, int bytes) |
4ef85a9c | 1048 | { |
f5a5ca79 | 1049 | return bdrv_co_pdiscard(bs->backing->bs, offset, bytes); |
4ef85a9c KW |
1050 | } |
1051 | ||
fd4a6493 KW |
1052 | static void bdrv_mirror_top_refresh_filename(BlockDriverState *bs, QDict *opts) |
1053 | { | |
18775ff3 VSO |
1054 | if (bs->backing == NULL) { |
1055 | /* we can be here after failed bdrv_attach_child in | |
1056 | * bdrv_set_backing_hd */ | |
1057 | return; | |
1058 | } | |
fd4a6493 KW |
1059 | bdrv_refresh_filename(bs->backing->bs); |
1060 | pstrcpy(bs->exact_filename, sizeof(bs->exact_filename), | |
1061 | bs->backing->bs->filename); | |
1062 | } | |
1063 | ||
4ef85a9c KW |
1064 | static void bdrv_mirror_top_close(BlockDriverState *bs) |
1065 | { | |
1066 | } | |
1067 | ||
1068 | static void bdrv_mirror_top_child_perm(BlockDriverState *bs, BdrvChild *c, | |
1069 | const BdrvChildRole *role, | |
e0995dc3 | 1070 | BlockReopenQueue *reopen_queue, |
4ef85a9c KW |
1071 | uint64_t perm, uint64_t shared, |
1072 | uint64_t *nperm, uint64_t *nshared) | |
1073 | { | |
1074 | /* Must be able to forward guest writes to the real image */ | |
1075 | *nperm = 0; | |
1076 | if (perm & BLK_PERM_WRITE) { | |
1077 | *nperm |= BLK_PERM_WRITE; | |
1078 | } | |
1079 | ||
1080 | *nshared = BLK_PERM_ALL; | |
1081 | } | |
1082 | ||
1083 | /* Dummy node that provides consistent read to its users without requiring it | |
1084 | * from its backing file and that allows writes on the backing file chain. */ | |
1085 | static BlockDriver bdrv_mirror_top = { | |
1086 | .format_name = "mirror_top", | |
1087 | .bdrv_co_preadv = bdrv_mirror_top_preadv, | |
1088 | .bdrv_co_pwritev = bdrv_mirror_top_pwritev, | |
1089 | .bdrv_co_pwrite_zeroes = bdrv_mirror_top_pwrite_zeroes, | |
1090 | .bdrv_co_pdiscard = bdrv_mirror_top_pdiscard, | |
1091 | .bdrv_co_flush = bdrv_mirror_top_flush, | |
3e4d0e72 | 1092 | .bdrv_co_block_status = bdrv_co_block_status_from_backing, |
fd4a6493 | 1093 | .bdrv_refresh_filename = bdrv_mirror_top_refresh_filename, |
4ef85a9c KW |
1094 | .bdrv_close = bdrv_mirror_top_close, |
1095 | .bdrv_child_perm = bdrv_mirror_top_child_perm, | |
1096 | }; | |
1097 | ||
71aa9867 | 1098 | static void mirror_start_job(const char *job_id, BlockDriverState *bs, |
47970dfb JS |
1099 | int creation_flags, BlockDriverState *target, |
1100 | const char *replaces, int64_t speed, | |
1101 | uint32_t granularity, int64_t buf_size, | |
274fccee | 1102 | BlockMirrorBackingMode backing_mode, |
09158f00 BC |
1103 | BlockdevOnError on_source_error, |
1104 | BlockdevOnError on_target_error, | |
0fc9f8ea | 1105 | bool unmap, |
097310b5 | 1106 | BlockCompletionFunc *cb, |
51ccfa2d | 1107 | void *opaque, |
09158f00 | 1108 | const BlockJobDriver *driver, |
b49f7ead | 1109 | bool is_none_mode, BlockDriverState *base, |
51ccfa2d | 1110 | bool auto_complete, const char *filter_node_name, |
045a2f82 | 1111 | bool is_mirror, |
51ccfa2d | 1112 | Error **errp) |
893f7eba PB |
1113 | { |
1114 | MirrorBlockJob *s; | |
4ef85a9c KW |
1115 | BlockDriverState *mirror_top_bs; |
1116 | bool target_graph_mod; | |
1117 | bool target_is_backing; | |
b2c2832c | 1118 | Error *local_err = NULL; |
d7086422 | 1119 | int ret; |
893f7eba | 1120 | |
eee13dfe | 1121 | if (granularity == 0) { |
341ebc2f | 1122 | granularity = bdrv_get_default_bitmap_granularity(target); |
eee13dfe PB |
1123 | } |
1124 | ||
31826642 | 1125 | assert(is_power_of_2(granularity)); |
eee13dfe | 1126 | |
48ac0a4d WC |
1127 | if (buf_size < 0) { |
1128 | error_setg(errp, "Invalid parameter 'buf-size'"); | |
1129 | return; | |
1130 | } | |
1131 | ||
1132 | if (buf_size == 0) { | |
1133 | buf_size = DEFAULT_MIRROR_BUF_SIZE; | |
1134 | } | |
5bc361b8 | 1135 | |
4ef85a9c KW |
1136 | /* In the case of active commit, add dummy driver to provide consistent |
1137 | * reads on the top, while disabling it in the intermediate nodes, and make | |
1138 | * the backing chain writable. */ | |
6cdbceb1 KW |
1139 | mirror_top_bs = bdrv_new_open_driver(&bdrv_mirror_top, filter_node_name, |
1140 | BDRV_O_RDWR, errp); | |
4ef85a9c KW |
1141 | if (mirror_top_bs == NULL) { |
1142 | return; | |
1143 | } | |
d3c8c674 KW |
1144 | if (!filter_node_name) { |
1145 | mirror_top_bs->implicit = true; | |
1146 | } | |
4ef85a9c | 1147 | mirror_top_bs->total_sectors = bs->total_sectors; |
228345bf HR |
1148 | mirror_top_bs->supported_write_flags = BDRV_REQ_WRITE_UNCHANGED; |
1149 | mirror_top_bs->supported_zero_flags = BDRV_REQ_WRITE_UNCHANGED; | |
19dd29e8 | 1150 | bdrv_set_aio_context(mirror_top_bs, bdrv_get_aio_context(bs)); |
4ef85a9c KW |
1151 | |
1152 | /* bdrv_append takes ownership of the mirror_top_bs reference, need to keep | |
7a25fcd0 | 1153 | * it alive until block_job_create() succeeds even if bs has no parent. */ |
4ef85a9c KW |
1154 | bdrv_ref(mirror_top_bs); |
1155 | bdrv_drained_begin(bs); | |
b2c2832c | 1156 | bdrv_append(mirror_top_bs, bs, &local_err); |
4ef85a9c KW |
1157 | bdrv_drained_end(bs); |
1158 | ||
b2c2832c KW |
1159 | if (local_err) { |
1160 | bdrv_unref(mirror_top_bs); | |
1161 | error_propagate(errp, local_err); | |
1162 | return; | |
1163 | } | |
1164 | ||
4ef85a9c | 1165 | /* Make sure that the source is not resized while the job is running */ |
75859b94 | 1166 | s = block_job_create(job_id, driver, NULL, mirror_top_bs, |
4ef85a9c KW |
1167 | BLK_PERM_CONSISTENT_READ, |
1168 | BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGED | | |
1169 | BLK_PERM_WRITE | BLK_PERM_GRAPH_MOD, speed, | |
c6cc12bf | 1170 | creation_flags, cb, opaque, errp); |
893f7eba | 1171 | if (!s) { |
4ef85a9c | 1172 | goto fail; |
893f7eba | 1173 | } |
7a25fcd0 HR |
1174 | /* The block job now has a reference to this node */ |
1175 | bdrv_unref(mirror_top_bs); | |
1176 | ||
4ef85a9c KW |
1177 | s->source = bs; |
1178 | s->mirror_top_bs = mirror_top_bs; | |
1179 | ||
1180 | /* No resize for the target either; while the mirror is still running, a | |
1181 | * consistent read isn't necessarily possible. We could possibly allow | |
1182 | * writes and graph modifications, though it would likely defeat the | |
1183 | * purpose of a mirror, so leave them blocked for now. | |
1184 | * | |
1185 | * In the case of active commit, things look a bit different, though, | |
1186 | * because the target is an already populated backing file in active use. | |
1187 | * We can allow anything except resize there.*/ | |
1188 | target_is_backing = bdrv_chain_contains(bs, target); | |
1189 | target_graph_mod = (backing_mode != MIRROR_LEAVE_BACKING_CHAIN); | |
1190 | s->target = blk_new(BLK_PERM_WRITE | BLK_PERM_RESIZE | | |
1191 | (target_graph_mod ? BLK_PERM_GRAPH_MOD : 0), | |
1192 | BLK_PERM_WRITE_UNCHANGED | | |
1193 | (target_is_backing ? BLK_PERM_CONSISTENT_READ | | |
1194 | BLK_PERM_WRITE | | |
1195 | BLK_PERM_GRAPH_MOD : 0)); | |
d7086422 KW |
1196 | ret = blk_insert_bs(s->target, target, errp); |
1197 | if (ret < 0) { | |
4ef85a9c | 1198 | goto fail; |
d7086422 | 1199 | } |
045a2f82 FZ |
1200 | if (is_mirror) { |
1201 | /* XXX: Mirror target could be a NBD server of target QEMU in the case | |
1202 | * of non-shared block migration. To allow migration completion, we | |
1203 | * have to allow "inactivate" of the target BB. When that happens, we | |
1204 | * know the job is drained, and the vcpus are stopped, so no write | |
1205 | * operation will be performed. Block layer already has assertions to | |
1206 | * ensure that. */ | |
1207 | blk_set_force_allow_inactivate(s->target); | |
1208 | } | |
e253f4b8 | 1209 | |
09158f00 | 1210 | s->replaces = g_strdup(replaces); |
b952b558 PB |
1211 | s->on_source_error = on_source_error; |
1212 | s->on_target_error = on_target_error; | |
03544a6e | 1213 | s->is_none_mode = is_none_mode; |
274fccee | 1214 | s->backing_mode = backing_mode; |
5bc361b8 | 1215 | s->base = base; |
eee13dfe | 1216 | s->granularity = granularity; |
48ac0a4d | 1217 | s->buf_size = ROUND_UP(buf_size, granularity); |
0fc9f8ea | 1218 | s->unmap = unmap; |
b49f7ead WC |
1219 | if (auto_complete) { |
1220 | s->should_complete = true; | |
1221 | } | |
b812f671 | 1222 | |
0db6e54a | 1223 | s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, NULL, errp); |
b8afb520 | 1224 | if (!s->dirty_bitmap) { |
88f9d1b3 | 1225 | goto fail; |
b8afb520 | 1226 | } |
10f3cd15 | 1227 | |
4ef85a9c | 1228 | /* Required permissions are already taken with blk_new() */ |
76d554e2 KW |
1229 | block_job_add_bdrv(&s->common, "target", target, 0, BLK_PERM_ALL, |
1230 | &error_abort); | |
1231 | ||
f3ede4b0 AG |
1232 | /* In commit_active_start() all intermediate nodes disappear, so |
1233 | * any jobs in them must be blocked */ | |
4ef85a9c | 1234 | if (target_is_backing) { |
f3ede4b0 AG |
1235 | BlockDriverState *iter; |
1236 | for (iter = backing_bs(bs); iter != target; iter = backing_bs(iter)) { | |
4ef85a9c KW |
1237 | /* XXX BLK_PERM_WRITE needs to be allowed so we don't block |
1238 | * ourselves at s->base (if writes are blocked for a node, they are | |
1239 | * also blocked for its backing file). The other options would be a | |
1240 | * second filter driver above s->base (== target). */ | |
1241 | ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0, | |
1242 | BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE, | |
1243 | errp); | |
1244 | if (ret < 0) { | |
1245 | goto fail; | |
1246 | } | |
f3ede4b0 AG |
1247 | } |
1248 | } | |
10f3cd15 | 1249 | |
5ccac6f1 | 1250 | trace_mirror_start(bs, s, opaque); |
da01ff7f | 1251 | job_start(&s->common.job); |
4ef85a9c KW |
1252 | return; |
1253 | ||
1254 | fail: | |
1255 | if (s) { | |
7a25fcd0 HR |
1256 | /* Make sure this BDS does not go away until we have completed the graph |
1257 | * changes below */ | |
1258 | bdrv_ref(mirror_top_bs); | |
1259 | ||
4ef85a9c KW |
1260 | g_free(s->replaces); |
1261 | blk_unref(s->target); | |
4ad35181 | 1262 | job_early_fail(&s->common.job); |
4ef85a9c KW |
1263 | } |
1264 | ||
c1cef672 FZ |
1265 | bdrv_child_try_set_perm(mirror_top_bs->backing, 0, BLK_PERM_ALL, |
1266 | &error_abort); | |
5fe31c25 | 1267 | bdrv_replace_node(mirror_top_bs, backing_bs(mirror_top_bs), &error_abort); |
7a25fcd0 HR |
1268 | |
1269 | bdrv_unref(mirror_top_bs); | |
893f7eba | 1270 | } |
03544a6e | 1271 | |
71aa9867 AG |
1272 | void mirror_start(const char *job_id, BlockDriverState *bs, |
1273 | BlockDriverState *target, const char *replaces, | |
5fba6c0e | 1274 | int64_t speed, uint32_t granularity, int64_t buf_size, |
274fccee HR |
1275 | MirrorSyncMode mode, BlockMirrorBackingMode backing_mode, |
1276 | BlockdevOnError on_source_error, | |
03544a6e | 1277 | BlockdevOnError on_target_error, |
6cdbceb1 | 1278 | bool unmap, const char *filter_node_name, Error **errp) |
03544a6e FZ |
1279 | { |
1280 | bool is_none_mode; | |
1281 | BlockDriverState *base; | |
1282 | ||
4b80ab2b JS |
1283 | if (mode == MIRROR_SYNC_MODE_INCREMENTAL) { |
1284 | error_setg(errp, "Sync mode 'incremental' not supported"); | |
d58d8453 JS |
1285 | return; |
1286 | } | |
03544a6e | 1287 | is_none_mode = mode == MIRROR_SYNC_MODE_NONE; |
760e0063 | 1288 | base = mode == MIRROR_SYNC_MODE_TOP ? backing_bs(bs) : NULL; |
bb02b65c | 1289 | mirror_start_job(job_id, bs, JOB_DEFAULT, target, replaces, |
274fccee | 1290 | speed, granularity, buf_size, backing_mode, |
51ccfa2d | 1291 | on_source_error, on_target_error, unmap, NULL, NULL, |
6cdbceb1 | 1292 | &mirror_job_driver, is_none_mode, base, false, |
045a2f82 | 1293 | filter_node_name, true, errp); |
03544a6e FZ |
1294 | } |
1295 | ||
fd62c609 | 1296 | void commit_active_start(const char *job_id, BlockDriverState *bs, |
47970dfb JS |
1297 | BlockDriverState *base, int creation_flags, |
1298 | int64_t speed, BlockdevOnError on_error, | |
0db832f4 | 1299 | const char *filter_node_name, |
78bbd910 FZ |
1300 | BlockCompletionFunc *cb, void *opaque, |
1301 | bool auto_complete, Error **errp) | |
03544a6e | 1302 | { |
4da83585 | 1303 | int orig_base_flags; |
cc67f4d1 | 1304 | Error *local_err = NULL; |
4da83585 JC |
1305 | |
1306 | orig_base_flags = bdrv_get_flags(base); | |
1307 | ||
20a63d2c FZ |
1308 | if (bdrv_reopen(base, bs->open_flags, errp)) { |
1309 | return; | |
1310 | } | |
4da83585 | 1311 | |
47970dfb | 1312 | mirror_start_job(job_id, bs, creation_flags, base, NULL, speed, 0, 0, |
71aa9867 | 1313 | MIRROR_LEAVE_BACKING_CHAIN, |
51ccfa2d | 1314 | on_error, on_error, true, cb, opaque, |
6cdbceb1 | 1315 | &commit_active_job_driver, false, base, auto_complete, |
045a2f82 | 1316 | filter_node_name, false, &local_err); |
0fb6395c | 1317 | if (local_err) { |
cc67f4d1 | 1318 | error_propagate(errp, local_err); |
4da83585 JC |
1319 | goto error_restore_flags; |
1320 | } | |
1321 | ||
1322 | return; | |
1323 | ||
1324 | error_restore_flags: | |
1325 | /* ignore error and errp for bdrv_reopen, because we want to propagate | |
1326 | * the original error */ | |
1327 | bdrv_reopen(base, orig_base_flags, NULL); | |
1328 | return; | |
03544a6e | 1329 | } |