]>
Commit | Line | Data |
---|---|---|
747ff602 JC |
1 | /* |
2 | * Live block commit | |
3 | * | |
4 | * Copyright Red Hat, Inc. 2012 | |
5 | * | |
6 | * Authors: | |
7 | * Jeff Cody <[email protected]> | |
8 | * Based on stream.c by Stefan Hajnoczi | |
9 | * | |
10 | * This work is licensed under the terms of the GNU LGPL, version 2 or later. | |
11 | * See the COPYING.LIB file in the top-level directory. | |
12 | * | |
13 | */ | |
14 | ||
80c71a24 | 15 | #include "qemu/osdep.h" |
dcbf37ce | 16 | #include "qemu/cutils.h" |
747ff602 | 17 | #include "trace.h" |
737e150e | 18 | #include "block/block_int.h" |
c87621ea | 19 | #include "block/blockjob_int.h" |
da34e65c | 20 | #include "qapi/error.h" |
cc7a8ea7 | 21 | #include "qapi/qmp/qerror.h" |
747ff602 | 22 | #include "qemu/ratelimit.h" |
373340b2 | 23 | #include "sysemu/block-backend.h" |
747ff602 JC |
24 | |
25 | enum { | |
26 | /* | |
27 | * Size of data buffer for populating the image file. This should be large | |
28 | * enough to process multiple clusters in a single call, so that populating | |
29 | * contiguous regions of the image is efficient. | |
30 | */ | |
31 | COMMIT_BUFFER_SIZE = 512 * 1024, /* in bytes */ | |
32 | }; | |
33 | ||
747ff602 JC |
34 | typedef struct CommitBlockJob { |
35 | BlockJob common; | |
8dfba279 | 36 | BlockDriverState *commit_top_bs; |
4653456a KW |
37 | BlockBackend *top; |
38 | BlockBackend *base; | |
22dffcbe | 39 | BlockDriverState *base_bs; |
92aa5c6d | 40 | BlockdevOnError on_error; |
e70cdc57 | 41 | bool base_read_only; |
df827336 | 42 | bool chain_frozen; |
54e26900 | 43 | char *backing_file_str; |
747ff602 JC |
44 | } CommitBlockJob; |
45 | ||
4653456a | 46 | static int coroutine_fn commit_populate(BlockBackend *bs, BlockBackend *base, |
d8a98584 | 47 | int64_t offset, uint64_t bytes, |
747ff602 JC |
48 | void *buf) |
49 | { | |
50 | int ret = 0; | |
51 | ||
d8a98584 | 52 | assert(bytes < SIZE_MAX); |
4653456a | 53 | |
08b6261f | 54 | ret = blk_co_pread(bs, offset, bytes, buf, 0); |
4653456a | 55 | if (ret < 0) { |
747ff602 JC |
56 | return ret; |
57 | } | |
58 | ||
08b6261f | 59 | ret = blk_co_pwrite(base, offset, bytes, buf, 0); |
4653456a | 60 | if (ret < 0) { |
747ff602 JC |
61 | return ret; |
62 | } | |
63 | ||
64 | return 0; | |
65 | } | |
66 | ||
22dffcbe | 67 | static int commit_prepare(Job *job) |
747ff602 | 68 | { |
1908a559 | 69 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
19ebd13e | 70 | |
df827336 AG |
71 | bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); |
72 | s->chain_frozen = false; | |
73 | ||
8dfba279 KW |
74 | /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before |
75 | * the normal backing chain can be restored. */ | |
76 | blk_unref(s->base); | |
22dffcbe JS |
77 | s->base = NULL; |
78 | ||
79 | /* FIXME: bdrv_drop_intermediate treats total failures and partial failures | |
80 | * identically. Further work is needed to disambiguate these cases. */ | |
81 | return bdrv_drop_intermediate(s->commit_top_bs, s->base_bs, | |
82 | s->backing_file_str); | |
83 | } | |
9e85cd5c | 84 | |
22dffcbe JS |
85 | static void commit_abort(Job *job) |
86 | { | |
87 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); | |
88 | BlockDriverState *top_bs = blk_bs(s->top); | |
89 | ||
df827336 AG |
90 | if (s->chain_frozen) { |
91 | bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); | |
92 | } | |
93 | ||
22dffcbe JS |
94 | /* Make sure commit_top_bs and top stay around until bdrv_replace_node() */ |
95 | bdrv_ref(top_bs); | |
96 | bdrv_ref(s->commit_top_bs); | |
97 | ||
98 | if (s->base) { | |
99 | blk_unref(s->base); | |
9e85cd5c SH |
100 | } |
101 | ||
22dffcbe JS |
102 | /* free the blockers on the intermediate nodes so that bdrv_replace_nodes |
103 | * can succeed */ | |
104 | block_job_remove_all_bdrv(&s->common); | |
105 | ||
106 | /* If bdrv_drop_intermediate() failed (or was not invoked), remove the | |
107 | * commit filter driver from the backing chain now. Do this as the final | |
108 | * step so that the 'consistent read' permission can be granted. | |
109 | * | |
110 | * XXX Can (or should) we somehow keep 'consistent read' blocked even | |
111 | * after the failed/cancelled commit job is gone? If we already wrote | |
112 | * something to base, the intermediate images aren't valid any more. */ | |
22dffcbe JS |
113 | bdrv_replace_node(s->commit_top_bs, backing_bs(s->commit_top_bs), |
114 | &error_abort); | |
115 | ||
116 | bdrv_unref(s->commit_top_bs); | |
117 | bdrv_unref(top_bs); | |
118 | } | |
119 | ||
120 | static void commit_clean(Job *job) | |
121 | { | |
122 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); | |
123 | ||
9e85cd5c SH |
124 | /* restore base open flags here if appropriate (e.g., change the base back |
125 | * to r/o). These reopens do not need to be atomic, since we won't abort | |
126 | * even on failure here */ | |
e70cdc57 AG |
127 | if (s->base_read_only) { |
128 | bdrv_reopen_set_read_only(s->base_bs, true, NULL); | |
9e85cd5c | 129 | } |
22dffcbe | 130 | |
9e85cd5c | 131 | g_free(s->backing_file_str); |
4653456a | 132 | blk_unref(s->top); |
9e85cd5c SH |
133 | } |
134 | ||
f67432a2 | 135 | static int coroutine_fn commit_run(Job *job, Error **errp) |
9e85cd5c | 136 | { |
f67432a2 | 137 | CommitBlockJob *s = container_of(job, CommitBlockJob, common.job); |
317a6676 | 138 | int64_t offset; |
f14a39cc | 139 | uint64_t delay_ns = 0; |
747ff602 | 140 | int ret = 0; |
51b0a488 | 141 | int64_t n = 0; /* bytes */ |
9e85cd5c | 142 | void *buf = NULL; |
747ff602 | 143 | int bytes_written = 0; |
05df8a6a | 144 | int64_t len, base_len; |
747ff602 | 145 | |
05df8a6a KW |
146 | ret = len = blk_getlength(s->top); |
147 | if (len < 0) { | |
9e85cd5c | 148 | goto out; |
747ff602 | 149 | } |
30a5c887 | 150 | job_progress_set_remaining(&s->common.job, len); |
747ff602 | 151 | |
4653456a | 152 | ret = base_len = blk_getlength(s->base); |
747ff602 | 153 | if (base_len < 0) { |
9e85cd5c | 154 | goto out; |
747ff602 JC |
155 | } |
156 | ||
05df8a6a | 157 | if (base_len < len) { |
c80d8b06 | 158 | ret = blk_truncate(s->base, len, false, PREALLOC_MODE_OFF, NULL); |
747ff602 | 159 | if (ret) { |
9e85cd5c | 160 | goto out; |
747ff602 JC |
161 | } |
162 | } | |
163 | ||
4653456a | 164 | buf = blk_blockalign(s->top, COMMIT_BUFFER_SIZE); |
747ff602 | 165 | |
05df8a6a | 166 | for (offset = 0; offset < len; offset += n) { |
747ff602 JC |
167 | bool copy; |
168 | ||
747ff602 | 169 | /* Note that even when no rate limit is applied we need to yield |
c57b6656 | 170 | * with no pending I/O here so that bdrv_drain_all() returns. |
747ff602 | 171 | */ |
5d43e86e | 172 | job_sleep_ns(&s->common.job, delay_ns); |
daa7f2f9 | 173 | if (job_is_cancelled(&s->common.job)) { |
747ff602 JC |
174 | break; |
175 | } | |
176 | /* Copy if allocated above the base */ | |
170d3bd3 | 177 | ret = bdrv_is_allocated_above(blk_bs(s->top), blk_bs(s->base), false, |
51b0a488 | 178 | offset, COMMIT_BUFFER_SIZE, &n); |
747ff602 | 179 | copy = (ret == 1); |
51b0a488 | 180 | trace_commit_one_iteration(s, offset, n, ret); |
747ff602 | 181 | if (copy) { |
51b0a488 EB |
182 | ret = commit_populate(s->top, s->base, offset, n, buf); |
183 | bytes_written += n; | |
747ff602 JC |
184 | } |
185 | if (ret < 0) { | |
1e8fb7f1 KW |
186 | BlockErrorAction action = |
187 | block_job_error_action(&s->common, false, s->on_error, -ret); | |
188 | if (action == BLOCK_ERROR_ACTION_REPORT) { | |
9e85cd5c | 189 | goto out; |
747ff602 JC |
190 | } else { |
191 | n = 0; | |
192 | continue; | |
193 | } | |
194 | } | |
195 | /* Publish progress */ | |
30a5c887 | 196 | job_progress_update(&s->common.job, n); |
f14a39cc | 197 | |
dee81d51 KW |
198 | if (copy) { |
199 | delay_ns = block_job_ratelimit_get_delay(&s->common, n); | |
2fe4bba1 KW |
200 | } else { |
201 | delay_ns = 0; | |
f14a39cc | 202 | } |
747ff602 JC |
203 | } |
204 | ||
205 | ret = 0; | |
206 | ||
9e85cd5c | 207 | out: |
747ff602 JC |
208 | qemu_vfree(buf); |
209 | ||
f67432a2 | 210 | return ret; |
747ff602 JC |
211 | } |
212 | ||
3fc4b10a | 213 | static const BlockJobDriver commit_job_driver = { |
33e9e9bd KW |
214 | .job_driver = { |
215 | .instance_size = sizeof(CommitBlockJob), | |
252291ea | 216 | .job_type = JOB_TYPE_COMMIT, |
80fa2c75 | 217 | .free = block_job_free, |
b15de828 | 218 | .user_resume = block_job_user_resume, |
f67432a2 | 219 | .run = commit_run, |
22dffcbe JS |
220 | .prepare = commit_prepare, |
221 | .abort = commit_abort, | |
222 | .clean = commit_clean | |
33e9e9bd | 223 | }, |
747ff602 JC |
224 | }; |
225 | ||
8dfba279 KW |
226 | static int coroutine_fn bdrv_commit_top_preadv(BlockDriverState *bs, |
227 | uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) | |
228 | { | |
229 | return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags); | |
230 | } | |
231 | ||
998b3a1e | 232 | static void bdrv_commit_top_refresh_filename(BlockDriverState *bs) |
dcbf37ce | 233 | { |
dcbf37ce KW |
234 | pstrcpy(bs->exact_filename, sizeof(bs->exact_filename), |
235 | bs->backing->bs->filename); | |
236 | } | |
91965658 | 237 | |
8dfba279 KW |
238 | static void bdrv_commit_top_child_perm(BlockDriverState *bs, BdrvChild *c, |
239 | const BdrvChildRole *role, | |
e0995dc3 | 240 | BlockReopenQueue *reopen_queue, |
8dfba279 KW |
241 | uint64_t perm, uint64_t shared, |
242 | uint64_t *nperm, uint64_t *nshared) | |
243 | { | |
244 | *nperm = 0; | |
245 | *nshared = BLK_PERM_ALL; | |
246 | } | |
247 | ||
248 | /* Dummy node that provides consistent read to its users without requiring it | |
249 | * from its backing file and that allows writes on the backing file chain. */ | |
250 | static BlockDriver bdrv_commit_top = { | |
91965658 KW |
251 | .format_name = "commit_top", |
252 | .bdrv_co_preadv = bdrv_commit_top_preadv, | |
3e4d0e72 | 253 | .bdrv_co_block_status = bdrv_co_block_status_from_backing, |
dcbf37ce | 254 | .bdrv_refresh_filename = bdrv_commit_top_refresh_filename, |
91965658 | 255 | .bdrv_child_perm = bdrv_commit_top_child_perm, |
8dfba279 KW |
256 | }; |
257 | ||
fd62c609 | 258 | void commit_start(const char *job_id, BlockDriverState *bs, |
5360782d JS |
259 | BlockDriverState *base, BlockDriverState *top, |
260 | int creation_flags, int64_t speed, | |
8254b6d9 | 261 | BlockdevOnError on_error, const char *backing_file_str, |
0db832f4 | 262 | const char *filter_node_name, Error **errp) |
747ff602 JC |
263 | { |
264 | CommitBlockJob *s; | |
3e4c5122 | 265 | BlockDriverState *iter; |
8dfba279 | 266 | BlockDriverState *commit_top_bs = NULL; |
747ff602 | 267 | Error *local_err = NULL; |
d7086422 | 268 | int ret; |
747ff602 | 269 | |
18da7f94 | 270 | assert(top != bs); |
747ff602 JC |
271 | if (top == base) { |
272 | error_setg(errp, "Invalid files for merge: top and base are the same"); | |
273 | return; | |
274 | } | |
275 | ||
75859b94 | 276 | s = block_job_create(job_id, &commit_job_driver, NULL, bs, 0, BLK_PERM_ALL, |
5360782d | 277 | speed, creation_flags, NULL, NULL, errp); |
834fe28d AG |
278 | if (!s) { |
279 | return; | |
280 | } | |
281 | ||
bde70715 | 282 | /* convert base to r/w, if necessary */ |
e70cdc57 AG |
283 | s->base_read_only = bdrv_is_read_only(base); |
284 | if (s->base_read_only) { | |
285 | if (bdrv_reopen_set_read_only(base, false, errp) != 0) { | |
d7086422 | 286 | goto fail; |
747ff602 JC |
287 | } |
288 | } | |
289 | ||
8dfba279 KW |
290 | /* Insert commit_top block node above top, so we can block consistent read |
291 | * on the backing chain below it */ | |
0db832f4 KW |
292 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, filter_node_name, 0, |
293 | errp); | |
8dfba279 KW |
294 | if (commit_top_bs == NULL) { |
295 | goto fail; | |
296 | } | |
d3c8c674 KW |
297 | if (!filter_node_name) { |
298 | commit_top_bs->implicit = true; | |
299 | } | |
e5182c1c HR |
300 | |
301 | /* So that we can always drop this node */ | |
302 | commit_top_bs->never_freeze = true; | |
303 | ||
0d0676a1 | 304 | commit_top_bs->total_sectors = top->total_sectors; |
8dfba279 | 305 | |
6a634199 | 306 | bdrv_append(commit_top_bs, top, &local_err); |
b69f00dd | 307 | if (local_err) { |
b69f00dd FZ |
308 | commit_top_bs = NULL; |
309 | error_propagate(errp, local_err); | |
310 | goto fail; | |
311 | } | |
8dfba279 KW |
312 | |
313 | s->commit_top_bs = commit_top_bs; | |
747ff602 | 314 | |
3e4c5122 AG |
315 | /* Block all nodes between top and base, because they will |
316 | * disappear from the chain after this operation. */ | |
317 | assert(bdrv_chain_contains(top, base)); | |
8dfba279 KW |
318 | for (iter = top; iter != base; iter = backing_bs(iter)) { |
319 | /* XXX BLK_PERM_WRITE needs to be allowed so we don't block ourselves | |
320 | * at s->base (if writes are blocked for a node, they are also blocked | |
321 | * for its backing file). The other options would be a second filter | |
322 | * driver above s->base. */ | |
323 | ret = block_job_add_bdrv(&s->common, "intermediate node", iter, 0, | |
324 | BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE, | |
325 | errp); | |
326 | if (ret < 0) { | |
327 | goto fail; | |
328 | } | |
3e4c5122 | 329 | } |
8dfba279 | 330 | |
df827336 AG |
331 | if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { |
332 | goto fail; | |
333 | } | |
334 | s->chain_frozen = true; | |
335 | ||
8dfba279 KW |
336 | ret = block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, errp); |
337 | if (ret < 0) { | |
338 | goto fail; | |
339 | } | |
340 | ||
d861ab3a KW |
341 | s->base = blk_new(s->common.job.aio_context, |
342 | BLK_PERM_CONSISTENT_READ | |
8dfba279 KW |
343 | | BLK_PERM_WRITE |
344 | | BLK_PERM_RESIZE, | |
345 | BLK_PERM_CONSISTENT_READ | |
346 | | BLK_PERM_GRAPH_MOD | |
347 | | BLK_PERM_WRITE_UNCHANGED); | |
d7086422 KW |
348 | ret = blk_insert_bs(s->base, base, errp); |
349 | if (ret < 0) { | |
350 | goto fail; | |
351 | } | |
cf312932 | 352 | blk_set_disable_request_queuing(s->base, true); |
22dffcbe | 353 | s->base_bs = base; |
4653456a | 354 | |
8dfba279 | 355 | /* Required permissions are already taken with block_job_add_bdrv() */ |
d861ab3a | 356 | s->top = blk_new(s->common.job.aio_context, 0, BLK_PERM_ALL); |
b247767a | 357 | ret = blk_insert_bs(s->top, top, errp); |
d7086422 KW |
358 | if (ret < 0) { |
359 | goto fail; | |
360 | } | |
cf312932 | 361 | blk_set_disable_request_queuing(s->top, true); |
4653456a | 362 | |
54e26900 | 363 | s->backing_file_str = g_strdup(backing_file_str); |
747ff602 | 364 | s->on_error = on_error; |
747ff602 | 365 | |
5ccac6f1 | 366 | trace_commit_start(bs, base, top, s); |
da01ff7f | 367 | job_start(&s->common.job); |
d7086422 KW |
368 | return; |
369 | ||
370 | fail: | |
df827336 AG |
371 | if (s->chain_frozen) { |
372 | bdrv_unfreeze_backing_chain(commit_top_bs, base); | |
373 | } | |
d7086422 KW |
374 | if (s->base) { |
375 | blk_unref(s->base); | |
376 | } | |
377 | if (s->top) { | |
378 | blk_unref(s->top); | |
379 | } | |
065abf9f AG |
380 | if (s->base_read_only) { |
381 | bdrv_reopen_set_read_only(base, true, NULL); | |
382 | } | |
2468eed3 AG |
383 | job_early_fail(&s->common.job); |
384 | /* commit_top_bs has to be replaced after deleting the block job, | |
385 | * otherwise this would fail because of lack of permissions. */ | |
8dfba279 | 386 | if (commit_top_bs) { |
bde70715 | 387 | bdrv_replace_node(commit_top_bs, top, &error_abort); |
8dfba279 | 388 | } |
747ff602 | 389 | } |
83fd6dd3 KW |
390 | |
391 | ||
d6a644bb | 392 | #define COMMIT_BUF_SIZE (2048 * BDRV_SECTOR_SIZE) |
83fd6dd3 KW |
393 | |
394 | /* commit COW file into the raw image */ | |
395 | int bdrv_commit(BlockDriverState *bs) | |
396 | { | |
f8e2bd53 | 397 | BlockBackend *src, *backing; |
d3f06759 KW |
398 | BlockDriverState *backing_file_bs = NULL; |
399 | BlockDriverState *commit_top_bs = NULL; | |
83fd6dd3 | 400 | BlockDriver *drv = bs->drv; |
d861ab3a | 401 | AioContext *ctx; |
d6a644bb | 402 | int64_t offset, length, backing_length; |
c742a364 | 403 | int ro; |
d6a644bb | 404 | int64_t n; |
83fd6dd3 KW |
405 | int ret = 0; |
406 | uint8_t *buf = NULL; | |
d3f06759 | 407 | Error *local_err = NULL; |
83fd6dd3 KW |
408 | |
409 | if (!drv) | |
410 | return -ENOMEDIUM; | |
411 | ||
412 | if (!bs->backing) { | |
413 | return -ENOTSUP; | |
414 | } | |
415 | ||
416 | if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, NULL) || | |
417 | bdrv_op_is_blocked(bs->backing->bs, BLOCK_OP_TYPE_COMMIT_TARGET, NULL)) { | |
418 | return -EBUSY; | |
419 | } | |
420 | ||
421 | ro = bs->backing->bs->read_only; | |
83fd6dd3 KW |
422 | |
423 | if (ro) { | |
c742a364 | 424 | if (bdrv_reopen_set_read_only(bs->backing->bs, false, NULL)) { |
83fd6dd3 KW |
425 | return -EACCES; |
426 | } | |
427 | } | |
428 | ||
d861ab3a KW |
429 | ctx = bdrv_get_aio_context(bs); |
430 | src = blk_new(ctx, BLK_PERM_CONSISTENT_READ, BLK_PERM_ALL); | |
431 | backing = blk_new(ctx, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL); | |
d7086422 | 432 | |
d3f06759 | 433 | ret = blk_insert_bs(src, bs, &local_err); |
d7086422 | 434 | if (ret < 0) { |
d3f06759 KW |
435 | error_report_err(local_err); |
436 | goto ro_cleanup; | |
437 | } | |
438 | ||
439 | /* Insert commit_top block node above backing, so we can write to it */ | |
440 | backing_file_bs = backing_bs(bs); | |
441 | ||
442 | commit_top_bs = bdrv_new_open_driver(&bdrv_commit_top, NULL, BDRV_O_RDWR, | |
443 | &local_err); | |
444 | if (commit_top_bs == NULL) { | |
445 | error_report_err(local_err); | |
d7086422 KW |
446 | goto ro_cleanup; |
447 | } | |
448 | ||
12fa4af6 KW |
449 | bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort); |
450 | bdrv_set_backing_hd(bs, commit_top_bs, &error_abort); | |
d3f06759 KW |
451 | |
452 | ret = blk_insert_bs(backing, backing_file_bs, &local_err); | |
d7086422 | 453 | if (ret < 0) { |
d3f06759 | 454 | error_report_err(local_err); |
d7086422 KW |
455 | goto ro_cleanup; |
456 | } | |
f8e2bd53 KW |
457 | |
458 | length = blk_getlength(src); | |
83fd6dd3 KW |
459 | if (length < 0) { |
460 | ret = length; | |
461 | goto ro_cleanup; | |
462 | } | |
463 | ||
f8e2bd53 | 464 | backing_length = blk_getlength(backing); |
83fd6dd3 KW |
465 | if (backing_length < 0) { |
466 | ret = backing_length; | |
467 | goto ro_cleanup; | |
468 | } | |
469 | ||
470 | /* If our top snapshot is larger than the backing file image, | |
471 | * grow the backing file image if possible. If not possible, | |
472 | * we must return an error */ | |
473 | if (length > backing_length) { | |
c80d8b06 HR |
474 | ret = blk_truncate(backing, length, false, PREALLOC_MODE_OFF, |
475 | &local_err); | |
83fd6dd3 | 476 | if (ret < 0) { |
ed3d2ec9 | 477 | error_report_err(local_err); |
83fd6dd3 KW |
478 | goto ro_cleanup; |
479 | } | |
480 | } | |
481 | ||
f8e2bd53 KW |
482 | /* blk_try_blockalign() for src will choose an alignment that works for |
483 | * backing as well, so no need to compare the alignment manually. */ | |
d6a644bb | 484 | buf = blk_try_blockalign(src, COMMIT_BUF_SIZE); |
83fd6dd3 KW |
485 | if (buf == NULL) { |
486 | ret = -ENOMEM; | |
487 | goto ro_cleanup; | |
488 | } | |
489 | ||
d6a644bb EB |
490 | for (offset = 0; offset < length; offset += n) { |
491 | ret = bdrv_is_allocated(bs, offset, COMMIT_BUF_SIZE, &n); | |
83fd6dd3 KW |
492 | if (ret < 0) { |
493 | goto ro_cleanup; | |
494 | } | |
495 | if (ret) { | |
d6a644bb | 496 | ret = blk_pread(src, offset, buf, n); |
83fd6dd3 KW |
497 | if (ret < 0) { |
498 | goto ro_cleanup; | |
499 | } | |
500 | ||
d6a644bb | 501 | ret = blk_pwrite(backing, offset, buf, n, 0); |
83fd6dd3 KW |
502 | if (ret < 0) { |
503 | goto ro_cleanup; | |
504 | } | |
505 | } | |
506 | } | |
507 | ||
508 | if (drv->bdrv_make_empty) { | |
509 | ret = drv->bdrv_make_empty(bs); | |
510 | if (ret < 0) { | |
511 | goto ro_cleanup; | |
512 | } | |
f8e2bd53 | 513 | blk_flush(src); |
83fd6dd3 KW |
514 | } |
515 | ||
516 | /* | |
517 | * Make sure all data we wrote to the backing device is actually | |
518 | * stable on disk. | |
519 | */ | |
f8e2bd53 | 520 | blk_flush(backing); |
83fd6dd3 KW |
521 | |
522 | ret = 0; | |
523 | ro_cleanup: | |
524 | qemu_vfree(buf); | |
525 | ||
f8e2bd53 | 526 | blk_unref(backing); |
d3f06759 | 527 | if (backing_file_bs) { |
12fa4af6 | 528 | bdrv_set_backing_hd(bs, backing_file_bs, &error_abort); |
d3f06759 KW |
529 | } |
530 | bdrv_unref(commit_top_bs); | |
531 | blk_unref(src); | |
f8e2bd53 | 532 | |
83fd6dd3 KW |
533 | if (ro) { |
534 | /* ignoring error return here */ | |
c742a364 | 535 | bdrv_reopen_set_read_only(bs->backing->bs, true, NULL); |
83fd6dd3 KW |
536 | } |
537 | ||
538 | return ret; | |
539 | } |