]> Git Repo - linux.git/commit
igb: Fix missing time sync events
authorVinicius Costa Gomes <[email protected]>
Tue, 20 Feb 2024 23:57:11 +0000 (15:57 -0800)
committerTony Nguyen <[email protected]>
Wed, 6 Mar 2024 17:20:23 +0000 (09:20 -0800)
commitee14cc9ea19ba9678177e2224a9c58cce5937c73
tree9067bcb213aceca32816f8a8e3782338a0077f35
parent244ae992e3e80e5c9c272c77324c831148457f95
igb: Fix missing time sync events

Fix "double" clearing of interrupts, which can cause external events
or timestamps to be missed.

The E1000_TSIRC Time Sync Interrupt Cause register can be cleared in two
ways, by either reading it or by writing '1' into the specific cause
bit. This is documented in section 8.16.1.

The following flow was used:
    1. read E1000_TSIRC into 'tsicr';
    2. handle the interrupts present into 'tsirc' and mark them in 'ack';
    3. write 'ack' into E1000_TSICR;

As both (1) and (3) will clear the interrupt cause, if the same
interrupt happens again between (1) and (3) it will be ignored,
causing events to be missed.

Remove the extra clear in (3).

Fixes: 00c65578b47b ("igb: enable internal PPS for the i210")
Acked-by: Richard Cochran <[email protected]>
Signed-off-by: Vinicius Costa Gomes <[email protected]>
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <[email protected]>
drivers/net/ethernet/intel/igb/igb_main.c
This page took 0.052927 seconds and 4 git commands to generate.