]> Git Repo - linux.git/commit
scsi: qla2xxx: Fix an integer overflow in sysfs code
authorDan Carpenter <[email protected]>
Wed, 30 Aug 2017 13:30:35 +0000 (16:30 +0300)
committerMartin K. Petersen <[email protected]>
Thu, 31 Aug 2017 02:06:20 +0000 (22:06 -0400)
commite6f77540c067b48dee10f1e33678415bfcc89017
tree61834b8b55fec5959bd84c127eb9814b39afe340
parent0208eeaa650c5c866a3242201678a19e6dc4a14e
scsi: qla2xxx: Fix an integer overflow in sysfs code

The value of "size" comes from the user.  When we add "start + size" it
could lead to an integer overflow bug.

It means we vmalloc() a lot more memory than we had intended.  I believe
that on 64 bit systems vmalloc() can succeed even if we ask it to
allocate huge 4GB buffers.  So we would get memory corruption and likely
a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().

Only root can trigger this bug.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
Cc: <[email protected]>
Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
Reported-by: shqking <[email protected]>
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
drivers/scsi/qla2xxx/qla_attr.c
This page took 0.05334 seconds and 4 git commands to generate.