]> Git Repo - linux.git/commit
objtool: Don't use ignore flag for fake jumps
authorJosh Poimboeuf <[email protected]>
Mon, 13 May 2019 17:01:31 +0000 (12:01 -0500)
committerIngo Molnar <[email protected]>
Mon, 13 May 2019 18:31:17 +0000 (20:31 +0200)
commite6da9567959e164f82bc81967e0d5b10dee870b4
treeff37fe29d3446f220a9a8fb5623dccf962670d53
parent82045dd85566d87128dcc66277cf1177d9930a4a
objtool: Don't use ignore flag for fake jumps

The ignore flag is set on fake jumps in order to keep
add_jump_destinations() from setting their jump_dest, since it already
got set when the fake jump was created.

But using the ignore flag is a bit of a hack.  It's normally used to
skip validation of an instruction, which doesn't really make sense for
fake jumps.

Also, after the next patch, using the ignore flag for fake jumps can
trigger a false "why am I validating an ignored function?" warning.

Instead just add an explicit check in add_jump_destinations() to skip
fake jumps.

Signed-off-by: Josh Poimboeuf <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/71abc072ff48b2feccc197723a9c52859476c068.1557766718.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <[email protected]>
tools/objtool/check.c
This page took 0.058565 seconds and 4 git commands to generate.