]> Git Repo - linux.git/commit
genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
authorBarry Song <[email protected]>
Tue, 2 Mar 2021 22:49:15 +0000 (11:49 +1300)
committerIngo Molnar <[email protected]>
Sat, 6 Mar 2021 11:48:00 +0000 (12:48 +0100)
commitcbe16f35bee6880becca6f20d2ebf6b457148552
tree4c82c004e0be2e9100af1407c11b5f35028a0d48
parenta38fd8748464831584a19438cbb3082b5a2dab15
genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()

Many drivers don't want interrupts enabled automatically via request_irq().
So they are handling this issue by either way of the below two:

(1)
  irq_set_status_flags(irq, IRQ_NOAUTOEN);
  request_irq(dev, irq...);

(2)
  request_irq(dev, irq...);
  disable_irq(irq);

The code in the second way is silly and unsafe. In the small time gap
between request_irq() and disable_irq(), interrupts can still come.

The code in the first way is safe though it's subobtimal.

Add a new IRQF_NO_AUTOEN flag which can be handed in by drivers to
request_irq() and request_nmi(). It prevents the automatic enabling of the
requested interrupt/nmi in the same safe way as #1 above. With that the
various usage sites of #1 and #2 above can be simplified and corrected.

Signed-off-by: Barry Song <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
include/linux/interrupt.h
kernel/irq/manage.c
This page took 0.061129 seconds and 4 git commands to generate.