]> Git Repo - linux.git/commit
kernel: make groups_sort calling a responsibility group_info allocators
authorThiago Rafael Becker <[email protected]>
Thu, 14 Dec 2017 23:33:12 +0000 (15:33 -0800)
committerLinus Torvalds <[email protected]>
Fri, 15 Dec 2017 00:00:49 +0000 (16:00 -0800)
commitbdcf0a423ea1c40bbb40e7ee483b50fc8aa3d758
tree942b1b8fa9b1e52503d5f9894d43674255813566
parent1f704fd0d14043e76e80f6b8b2251b9b2cedcca6
kernel: make groups_sort calling a responsibility group_info allocators

In testing, we found that nfsd threads may call set_groups in parallel
for the same entry cached in auth.unix.gid, racing in the call of
groups_sort, corrupting the groups for that entry and leading to
permission denials for the client.

This patch:
 - Make groups_sort globally visible.
 - Move the call to groups_sort to the modifiers of group_info
 - Remove the call to groups_sort from set_groups

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thiago Rafael Becker <[email protected]>
Reviewed-by: Matthew Wilcox <[email protected]>
Reviewed-by: NeilBrown <[email protected]>
Acked-by: "J. Bruce Fields" <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
arch/s390/kernel/compat_linux.c
fs/nfsd/auth.c
include/linux/cred.h
kernel/groups.c
kernel/uid16.c
net/sunrpc/auth_gss/gss_rpc_xdr.c
net/sunrpc/auth_gss/svcauth_gss.c
net/sunrpc/svcauth_unix.c
This page took 0.058035 seconds and 4 git commands to generate.