]> Git Repo - linux.git/commit
bpf: do not use reciprocal divide
authorEric Dumazet <[email protected]>
Wed, 15 Jan 2014 14:50:07 +0000 (06:50 -0800)
committerDavid S. Miller <[email protected]>
Thu, 16 Jan 2014 01:02:08 +0000 (17:02 -0800)
commitaee636c4809fa54848ff07a899b326eb1f9987a2
tree8f0c327f82dd7d5056dc487064f05f3f804f2fea
parentba42fad0964a41f0830e80c1b6be49c1e6bfcc01
bpf: do not use reciprocal divide

At first Jakub Zawadzki noticed that some divisions by reciprocal_divide
were not correct. (off by one in some cases)
http://www.wireshark.org/~darkjames/reciprocal-buggy.c

He could also show this with BPF:
http://www.wireshark.org/~darkjames/set-and-dump-filter-k-bug.c

The reciprocal divide in linux kernel is not generic enough,
lets remove its use in BPF, as it is not worth the pain with
current cpus.

Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: Jakub Zawadzki <[email protected]>
Cc: Mircea Gherzan <[email protected]>
Cc: Daniel Borkmann <[email protected]>
Cc: Hannes Frederic Sowa <[email protected]>
Cc: Matt Evans <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: Heiko Carstens <[email protected]>
Cc: David S. Miller <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
arch/arm/net/bpf_jit_32.c
arch/powerpc/net/bpf_jit_comp.c
arch/s390/net/bpf_jit_comp.c
arch/sparc/net/bpf_jit_comp.c
arch/x86/net/bpf_jit_comp.c
net/core/filter.c
This page took 0.0701 seconds and 4 git commands to generate.