]> Git Repo - linux.git/commit
vfio/gvt: fix DRM_I915_GVT dependency on VFIO_MDEV
authorArnd Bergmann <[email protected]>
Thu, 22 Apr 2021 13:35:33 +0000 (15:35 +0200)
committerAlex Williamson <[email protected]>
Tue, 27 Apr 2021 19:36:54 +0000 (13:36 -0600)
commitadaeb718d46f6b42a3fc1dffd4f946f26b33779a
treea0373c1c8fc15be3bbf59af07174ca0cf0e61d69
parent43dcf6ccf8953a868dfd194ff2fad279eb55883e
vfio/gvt: fix DRM_I915_GVT dependency on VFIO_MDEV

The Kconfig dependency is incomplete since DRM_I915_GVT is a 'bool'
symbol that depends on the 'tristate' VFIO_MDEV. This allows a
configuration with VFIO_MDEV=m, DRM_I915_GVT=y and DRM_I915=y that
causes a link failure:

x86_64-linux-ld: drivers/gpu/drm/i915/gvt/gvt.o: in function `available_instances_show':
gvt.c:(.text+0x67a): undefined reference to `mtype_get_parent_dev'
x86_64-linux-ld: gvt.c:(.text+0x6a5): undefined reference to `mtype_get_type_group_id'
x86_64-linux-ld: drivers/gpu/drm/i915/gvt/gvt.o: in function `description_show':
gvt.c:(.text+0x76e): undefined reference to `mtype_get_parent_dev'
x86_64-linux-ld: gvt.c:(.text+0x799): undefined reference to `mtype_get_type_group_id'

Clarify the dependency by specifically disallowing the broken
configuration. If VFIO_MDEV is built-in, it will work, but if
VFIO_MDEV=m, the i915 driver cannot be built-in here.

Fixes: 07e543f4f9d1 ("vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV")
Fixes: 9169cff168ff ("vfio/mdev: Correct the function signatures for the mdev_type_attributes")
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Zhenyu Wang <[email protected]>
Message-Id: <20210422133547.1861063[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
drivers/gpu/drm/i915/Kconfig
This page took 0.056371 seconds and 4 git commands to generate.