]> Git Repo - linux.git/commit
net: dsa: mt7530: replace deprecated strncpy with ethtool_sprintf
authorJustin Stitt <[email protected]>
Mon, 9 Oct 2023 18:29:19 +0000 (18:29 +0000)
committerJakub Kicinski <[email protected]>
Thu, 12 Oct 2023 00:25:48 +0000 (17:25 -0700)
commitac49b992578d366bde19cfb9316d07784e255d2c
tree964ca9dfd882a436143d999cd7ef112af5dbb026
parentfda9e465a9d92f59cae40d0c2a2450797db6ec66
net: dsa: mt7530: replace deprecated strncpy with ethtool_sprintf

`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <[email protected]>
Reviewed-by: Kees Cook <[email protected]>
Acked-by: Daniel Golle <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Link: https://lore.kernel.org/r/20231009-strncpy-drivers-net-dsa-mt7530-c-v1-1-ec6677a6436a@google.com
Signed-off-by: Jakub Kicinski <[email protected]>
drivers/net/dsa/mt7530.c
This page took 0.053261 seconds and 4 git commands to generate.