]> Git Repo - linux.git/commit
mm: hwpoison: drop lru_add_drain_all() in __soft_offline_page()
authorNaoya Horiguchi <[email protected]>
Thu, 12 Feb 2015 23:00:25 +0000 (15:00 -0800)
committerLinus Torvalds <[email protected]>
Fri, 13 Feb 2015 02:54:11 +0000 (18:54 -0800)
commit9ab3b598d2dfbdb0153ffa7e4b1456bbff59a25d
tree5eea7682b59e69f24c91b0606f7b4760fb6621a9
parent84109e15ddc8fe00c832d5228ca2aedf95d13b97
mm: hwpoison: drop lru_add_drain_all() in __soft_offline_page()

A race condition starts to be visible in recent mmotm, where a PG_hwpoison
flag is set on a migration source page *before* it's back in buddy page
poo= l.

This is problematic because no page flag is supposed to be set when
freeing (see __free_one_page().) So the user-visible effect of this race
is that it could trigger the BUG_ON() when soft-offlining is called.

The root cause is that we call lru_add_drain_all() to make sure that the
page is in buddy, but that doesn't work because this function just
schedule= s a work item and doesn't wait its completion.
drain_all_pages() does drainin= g directly, so simply dropping
lru_add_drain_all() solves this problem.

Fixes: f15bdfa802bf ("mm/memory-failure.c: fix memory leak in successful soft offlining")
Signed-off-by: Naoya Horiguchi <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Chen Gong <[email protected]>
Cc: <[email protected]> [3.11+]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/memory-failure.c
This page took 0.054592 seconds and 4 git commands to generate.