]> Git Repo - linux.git/commit
misc/mei: Add NULL check to component match callback functions
authorWon Chung <[email protected]>
Mon, 18 Apr 2022 17:59:31 +0000 (17:59 +0000)
committerMika Westerberg <[email protected]>
Fri, 29 Apr 2022 09:17:22 +0000 (12:17 +0300)
commit84d4333c1e28cedfad37c5347b4a94a3565a454f
treedbf9dac7d5fbc5af6c119d1bad180a8600a29c4b
parent9d2d0a5cf0ca063f417681cc33e767ce52615286
misc/mei: Add NULL check to component match callback functions

Currently, component_match callback functions used in mei refers to the
driver name, assuming that the component device being matched has a
driver bound. It can cause a NULL pointer dereference when a device
without a driver bound registers a component. This is due to the nature
of the component framework where all registered components are matched
in any component_match callback functions. So even if a component is
registered by a totally irrelevant device, that component is also
shared to these callbacks for i915 driver.

To prevent totally irrelevant device being matched for i915 and causing
a NULL pointer dereference for checking driver name, add a NULL check on
dev->driver to check if there is a driver bound before checking the
driver name.

In the future, the string compare on the driver name, "i915" may need to
be refactored too.

Reviewed-by: Heikki Krogerus <[email protected]>
Reviewed-by: Prashant Malani <[email protected]>
Signed-off-by: Won Chung <[email protected]>
Acked-by: Tomas Winkler <[email protected]>
Signed-off-by: Mika Westerberg <[email protected]>
drivers/misc/mei/hdcp/mei_hdcp.c
drivers/misc/mei/pxp/mei_pxp.c
This page took 0.063194 seconds and 4 git commands to generate.