]> Git Repo - linux.git/commit
pstore: Switch pmsg_lock to an rt_mutex to avoid priority inversion
authorJohn Stultz <[email protected]>
Wed, 14 Dec 2022 23:18:34 +0000 (23:18 +0000)
committerKees Cook <[email protected]>
Thu, 15 Dec 2022 03:37:42 +0000 (19:37 -0800)
commit76d62f24db07f22ccf9bc18ca793c27d4ebef721
treea1a53f0abbae596ad1bb60836c3447092b16c5b7
parente6b842741b4f39007215fd7e545cb55aa3d358a2
pstore: Switch pmsg_lock to an rt_mutex to avoid priority inversion

Wei Wang reported seeing priority inversion caused latencies
caused by contention on pmsg_lock, and suggested it be switched
to a rt_mutex.

I was initially hesitant this would help, as the tasks in that
trace all seemed to be SCHED_NORMAL, so the benefit would be
limited to only nice boosting.

However, another similar issue was raised where the priority
inversion was seen did involve a blocked RT task so it is clear
this would be helpful in that case.

Cc: Wei Wang <[email protected]>
Cc: Midas Chien<[email protected]>
Cc: Connor O'Brien <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: [email protected]
Fixes: 9d5438f462ab ("pstore: Add pmsg - user-space accessible pstore object")
Reported-by: Wei Wang <[email protected]>
Signed-off-by: John Stultz <[email protected]>
Signed-off-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
fs/pstore/pmsg.c
This page took 0.05376 seconds and 4 git commands to generate.