]> Git Repo - linux.git/commit
md/raid6: Fix anomily when recovering a single device in RAID6.
authorNeilBrown <[email protected]>
Mon, 3 Apr 2017 02:11:32 +0000 (12:11 +1000)
committerShaohua Li <[email protected]>
Mon, 10 Apr 2017 17:35:27 +0000 (10:35 -0700)
commit7471fb77ce4dc4cb81291189947fcdf621a97987
tree8b8e0ee2aec838c866e15634c43e3f98215b5b88
parent583da48e388f472e8818d9bb60ef6a1d40ee9f9d
md/raid6: Fix anomily when recovering a single device in RAID6.

When recoverying a single missing/failed device in a RAID6,
those stripes where the Q block is on the missing device are
handled a bit differently.  In these cases it is easy to
check that the P block is correct, so we do.  This results
in the P block be destroy.  Consequently the P block needs
to be read a second time in order to compute Q.  This causes
lots of seeks and hurts performance.

It shouldn't be necessary to re-read P as it can be computed
from the DATA.  But we only compute blocks on missing
devices, since c337869d9501 ("md: do not compute parity
unless it is on a failed drive").

So relax the change made in that commit to allow computing
of the P block in a RAID6 which it is the only missing that
block.

This makes RAID6 recovery run much faster as the disk just
"before" the recovering device is no longer seeking
back-and-forth.

Reported-by-tested-by: Brad Campbell <[email protected]>
Reviewed-by: Dan Williams <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
Signed-off-by: Shaohua Li <[email protected]>
drivers/md/raid5.c
This page took 0.053729 seconds and 4 git commands to generate.