]> Git Repo - linux.git/commit
selftests: vm: remove dependecy from internal kernel macros
authorMuhammad Usama Anjum <[email protected]>
Wed, 19 Jan 2022 10:15:31 +0000 (15:15 +0500)
committerShuah Khan <[email protected]>
Thu, 24 Feb 2022 00:21:10 +0000 (17:21 -0700)
commit681696862bc1823595c05960a83766d1aa965c17
tree39d553d15796fdd4372b736ddc8925436cdcf2e1
parent4a8900207abdc629933f07329bd884c60b50f074
selftests: vm: remove dependecy from internal kernel macros

The defination of swap() is used from kernel's internal header when this
test is built in source tree. The build fails when this test is built
out of source tree as defination of swap() isn't found. Selftests
shouldn't depend on kernel's internal header files. They can only depend
on uapi header files. Add the defination of swap() to fix the build
error:

gcc -Wall  -I/linux_mainline2/build/usr/include -no-pie    userfaultfd.c -lrt -lpthread -o /linux_mainline2/build/kselftest/vm/userfaultfd
userfaultfd.c: In function ‘userfaultfd_stress’:
userfaultfd.c:1530:3: warning: implicit declaration of function ‘swap’; did you mean ‘swab’? [-Wimplicit-function-declaration]
 1530 |   swap(area_src, area_dst);
      |   ^~~~
      |   swab
/usr/bin/ld: /tmp/cclUUH7V.o: in function `userfaultfd_stress':
userfaultfd.c:(.text+0x4d64): undefined reference to `swap'
/usr/bin/ld: userfaultfd.c:(.text+0x4d82): undefined reference to `swap'
collect2: error: ld returned 1 exit status

Fixes: 2c769ed7137a ("tools/testing/selftests/vm/userfaultfd.c: use swap() to make code cleaner")
Signed-off-by: Muhammad Usama Anjum <[email protected]>
Reviewed-by: Alistair Popple <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
tools/testing/selftests/vm/userfaultfd.c
This page took 0.059679 seconds and 4 git commands to generate.