]> Git Repo - linux.git/commit
spi: cadence: Fix default polarity of native chipselect
authorLinus Walleij <[email protected]>
Wed, 16 Jan 2019 08:21:09 +0000 (09:21 +0100)
committerMark Brown <[email protected]>
Thu, 24 Jan 2019 19:03:11 +0000 (19:03 +0000)
commit6046f5407ff031b7852ada18141238ce2fe70011
tree9ee089b805a9ac4da95b91799454796a45cdc9d5
parent6e0a32d6f376ea22a34ae3a8df60adafbcdb0c86
spi: cadence: Fix default polarity of native chipselect

The Cadence controller also supports platforms specifying
native chipselects. When I enforce the use of high CS
for drivers opting in for using GPIO descriptors, I
inadvertedly switched the driver to also use active
high chip select for native chip selects.

Fix this by inverting the logic in the callback for the
native chip select. Rename the parameter from "is_high"
(which is interpreted as being high when 0, which is
confusing, I will not make any drug-related jokes here)
to "enabled" which is more intuitive, especially now that
it is true when CS is supposed to be enabled.

Cc: Wei Yongjun <[email protected]>
Fixes: cfeefa79dc37 ("spi: cadence: Convert to use CS GPIO descriptors")
Signed-off-by: Linus Walleij <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
drivers/spi/spi-cadence.c
This page took 0.052738 seconds and 4 git commands to generate.