]> Git Repo - linux.git/commit
KVM: Prevent module exit until all VMs are freed
authorDavid Matlack <[email protected]>
Thu, 3 Mar 2022 18:33:27 +0000 (18:33 +0000)
committerPaolo Bonzini <[email protected]>
Tue, 29 Mar 2022 17:02:25 +0000 (13:02 -0400)
commit5f6de5cbebee925a612856fce6f9182bb3eee0db
tree5b7d3415996259b5f6eea3e98cf88cddd618acf7
parentc9b8fecddb5bb4b67e351bbaeaa648a6f7456912
KVM: Prevent module exit until all VMs are freed

Tie the lifetime the KVM module to the lifetime of each VM via
kvm.users_count. This way anything that grabs a reference to the VM via
kvm_get_kvm() cannot accidentally outlive the KVM module.

Prior to this commit, the lifetime of the KVM module was tied to the
lifetime of /dev/kvm file descriptors, VM file descriptors, and vCPU
file descriptors by their respective file_operations "owner" field.
This approach is insufficient because references grabbed via
kvm_get_kvm() do not prevent closing any of the aforementioned file
descriptors.

This fixes a long standing theoretical bug in KVM that at least affects
async page faults. kvm_setup_async_pf() grabs a reference via
kvm_get_kvm(), and drops it in an asynchronous work callback. Nothing
prevents the VM file descriptor from being closed and the KVM module
from being unloaded before this callback runs.

Fixes: af585b921e5d ("KVM: Halt vcpu if page it tries to access is swapped out")
Fixes: 3d3aab1b973b ("KVM: set owner of cpu and vm file operations")
Cc: [email protected]
Suggested-by: Ben Gardon <[email protected]>
[ Based on a patch from Ben implemented for Google's kernel. ]
Signed-off-by: David Matlack <[email protected]>
Message-Id: <20220303183328.1499189[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
virt/kvm/kvm_main.c
This page took 0.05223 seconds and 4 git commands to generate.