]> Git Repo - linux.git/commit
proc: Track /proc/$pid/attr/ opener mm_struct
authorKees Cook <[email protected]>
Tue, 8 Jun 2021 17:12:21 +0000 (10:12 -0700)
committerLinus Torvalds <[email protected]>
Tue, 8 Jun 2021 17:24:09 +0000 (10:24 -0700)
commit591a22c14d3f45cc38bd1931c593c221df2f1881
treea401c5309eec40ab5304390474e923871e96c509
parent4c8684fe555e95100030bd330d0a2780ac27952e
proc: Track /proc/$pid/attr/ opener mm_struct

Commit bfb819ea20ce ("proc: Check /proc/$pid/attr/ writes against file opener")
tried to make sure that there could not be a confusion between the opener of
a /proc/$pid/attr/ file and the writer. It used struct cred to make sure
the privileges didn't change. However, there were existing cases where a more
privileged thread was passing the opened fd to a differently privileged thread
(during container setup). Instead, use mm_struct to track whether the opener
and writer are still the same process. (This is what several other proc files
already do, though for different reasons.)

Reported-by: Christian Brauner <[email protected]>
Reported-by: Andrea Righi <[email protected]>
Tested-by: Andrea Righi <[email protected]>
Fixes: bfb819ea20ce ("proc: Check /proc/$pid/attr/ writes against file opener")
Cc: [email protected]
Signed-off-by: Kees Cook <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/proc/base.c
This page took 0.07379 seconds and 4 git commands to generate.