]> Git Repo - linux.git/commit
hugetlbfs: fix memory leak for resv_map
authorMike Kravetz <[email protected]>
Sat, 6 Apr 2019 01:39:06 +0000 (18:39 -0700)
committerLinus Torvalds <[email protected]>
Sat, 6 Apr 2019 02:02:31 +0000 (16:02 -1000)
commit58b6e5e8f1addd44583d61b0a03c0f5519527e35
tree26842d20ba459c65b3345d36d93aab955d63a2af
parentfcae96ff96538f66e7acd5d4e0f2e7516ff8cbd0
hugetlbfs: fix memory leak for resv_map

When mknod is used to create a block special file in hugetlbfs, it will
allocate an inode and kmalloc a 'struct resv_map' via resv_map_alloc().
inode->i_mapping->private_data will point the newly allocated resv_map.
However, when the device special file is opened bd_acquire() will set
inode->i_mapping to bd_inode->i_mapping.  Thus the pointer to the
allocated resv_map is lost and the structure is leaked.

Programs to reproduce:
        mount -t hugetlbfs nodev hugetlbfs
        mknod hugetlbfs/dev b 0 0
        exec 30<> hugetlbfs/dev
        umount hugetlbfs/

resv_map structures are only needed for inodes which can have associated
page allocations.  To fix the leak, only allocate resv_map for those
inodes which could possibly be associated with page allocations.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Mike Kravetz <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Reported-by: Yufen Yu <[email protected]>
Suggested-by: Yufen Yu <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/hugetlbfs/inode.c
This page took 0.054249 seconds and 4 git commands to generate.