]> Git Repo - linux.git/commit
coresight: etm-perf: Clarify comment on perf options
authorLeo Yan <[email protected]>
Thu, 11 Feb 2021 17:20:36 +0000 (10:20 -0700)
committerGreg Kroah-Hartman <[email protected]>
Thu, 11 Feb 2021 17:31:48 +0000 (18:31 +0100)
commit53abf3fe831756261f399dad03ccc07235296acf
tree63fbbc0fffcb36bf812676bdc6a15d425c3b0296
parent48139bad913d660d1f6a72ee215297e6749bc6f1
coresight: etm-perf: Clarify comment on perf options

In theory, the options should be arbitrary values and are neutral for
any ETM version; so far perf tool uses ETMv3.5/PTM ETMCR config bits
except for register's bit definitions, also uses as options.

This can introduce confusion, especially if we want to add a new option
but the new option is not supported by ETMv3.5/PTM ETMCR.  But on the
other hand, we cannot change options since these options are generic
CoreSight PMU ABI.

For easier maintenance and avoid confusion, this patch refines the
comment to clarify perf options, and gives out the background info for
these bits are coming from ETMv3.5/PTM.  Afterwards, we should take
these options as general knobs, and if there have any confliction with
ETMv3.5/PTM, should consider to define saperate macros for ETMv3.5/PTM
ETMCR config bits.

Suggested-by: Suzuki K Poulose <[email protected]>
Reviewed-by: Suzuki K Poulose <[email protected]>
Signed-off-by: Leo Yan <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
drivers/hwtracing/coresight/coresight-etm-perf.c
include/linux/coresight-pmu.h
This page took 0.057181 seconds and 4 git commands to generate.