]> Git Repo - linux.git/commit
x86/ioremap: Improve iounmap() address range checks
authorMax Ramanouski <[email protected]>
Sat, 24 Aug 2024 22:01:11 +0000 (01:01 +0300)
committerDave Hansen <[email protected]>
Mon, 26 Aug 2024 17:19:55 +0000 (10:19 -0700)
commit50c6dbdfd16e312382842198a7919341ad480e05
treee2f18794c085735534c4efd20518b0114430f55f
parentd4245fd4a62931aebd1c5e6b7b6f51b6ef7ad087
x86/ioremap: Improve iounmap() address range checks

Allowing iounmap() on memory that was not ioremap()'d in the first
place is obviously a bad idea.  There is currently a feeble attempt to
avoid errant iounmap()s by checking to see if the address is below
"high_memory".  But that's imprecise at best because there are plenty
of high addresses that are also invalid to call iounmap() on.

Thankfully, there is a more precise helper: is_ioremap_addr().  x86
just does not use it in iounmap().

Restrict iounmap() to addresses in the ioremap region, by using
is_ioremap_addr(). This aligns x86 closer to the generic iounmap()
implementation.

Additionally, add a warning in case there is an attempt to iounmap()
invalid memory.  This replaces an existing silent return and will
help alert folks to any incorrect usage of iounmap().

Due to VMALLOC_START on i386 not being present in asm/pgtable.h,
include for asm/vmalloc.h had to be added to include/linux/ioremap.h.

[ dhansen: tweak subject and changelog ]

Signed-off-by: Max Ramanouski <[email protected]>
Signed-off-by: Dave Hansen <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Alistair Popple <[email protected]>
Link: https://lore.kernel.org/all/20240824220111.84441-1-max8rr8%40gmail.com
arch/x86/mm/ioremap.c
include/linux/ioremap.h
This page took 0.058625 seconds and 4 git commands to generate.