]> Git Repo - linux.git/commit
xsk: Add TX timestamp and TX checksum offload support
authorStanislav Fomichev <[email protected]>
Mon, 27 Nov 2023 19:03:08 +0000 (11:03 -0800)
committerAlexei Starovoitov <[email protected]>
Wed, 29 Nov 2023 22:59:40 +0000 (14:59 -0800)
commit48eb03dd26304c24f03bdbb9382e89c8564e71df
treeac572d4d71fa6012c7267efc03d17c18bcb11e5c
parent341ac980eab90ac1f6c22ee9f9da83ed9604d899
xsk: Add TX timestamp and TX checksum offload support

This change actually defines the (initial) metadata layout
that should be used by AF_XDP userspace (xsk_tx_metadata).
The first field is flags which requests appropriate offloads,
followed by the offload-specific fields. The supported per-device
offloads are exported via netlink (new xsk-flags).

The offloads themselves are still implemented in a bit of a
framework-y fashion that's left from my initial kfunc attempt.
I'm introducing new xsk_tx_metadata_ops which drivers are
supposed to implement. The drivers are also supposed
to call xsk_tx_metadata_request/xsk_tx_metadata_complete in
the right places. Since xsk_tx_metadata_{request,_complete}
are static inline, we don't incur any extra overhead doing
indirect calls.

The benefit of this scheme is as follows:
- keeps all metadata layout parsing away from driver code
- makes it easy to grep and see which drivers implement what
- don't need any extra flags to maintain to keep track of what
  offloads are implemented; if the callback is implemented - the offload
  is supported (used by netlink reporting code)

Two offloads are defined right now:
1. XDP_TXMD_FLAGS_CHECKSUM: skb-style csum_start+csum_offset
2. XDP_TXMD_FLAGS_TIMESTAMP: writes TX timestamp back into metadata
   area upon completion (tx_timestamp field)

XDP_TXMD_FLAGS_TIMESTAMP is also implemented for XDP_COPY mode: it writes
SW timestamp from the skb destructor (note I'm reusing hwtstamps to pass
metadata pointer).

The struct is forward-compatible and can be extended in the future
by appending more fields.

Reviewed-by: Song Yoong Siang <[email protected]>
Signed-off-by: Stanislav Fomichev <[email protected]>
Acked-by: Jakub Kicinski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Alexei Starovoitov <[email protected]>
15 files changed:
Documentation/netlink/specs/netdev.yaml
include/linux/netdevice.h
include/linux/skbuff.h
include/net/xdp_sock.h
include/net/xdp_sock_drv.h
include/net/xsk_buff_pool.h
include/uapi/linux/if_xdp.h
include/uapi/linux/netdev.h
net/core/netdev-genl.c
net/xdp/xsk.c
net/xdp/xsk_queue.h
tools/include/uapi/linux/if_xdp.h
tools/include/uapi/linux/netdev.h
tools/net/ynl/generated/netdev-user.c
tools/net/ynl/generated/netdev-user.h
This page took 0.074801 seconds and 4 git commands to generate.