]> Git Repo - linux.git/commit
kbuild: use 4-space indentation when followed by conditionals
authorMasahiro Yamada <[email protected]>
Fri, 2 Feb 2024 01:31:42 +0000 (10:31 +0900)
committerMasahiro Yamada <[email protected]>
Wed, 14 Feb 2024 21:05:44 +0000 (06:05 +0900)
commit3b9ab248bc45abf8c2365ed3eec86cdefd4d626a
treeeccbfbd64da268a3991fecc16c591a10526df5ba
parent841c35169323cd833294798e58b9bf63fa4fa1de
kbuild: use 4-space indentation when followed by conditionals

GNU Make manual [1] clearly forbids a tab at the beginning of the
conditional directive line:
 "Extra spaces are allowed and ignored at the beginning of the
  conditional directive line, but a tab is not allowed."

This will not work for the next release of GNU Make, hence commit
82175d1f9430 ("kbuild: Replace tabs with spaces when followed by
conditionals") replaced the inappropriate tabs with 8 spaces.

However, the 8-space indentation cannot be visually distinguished.
Linus suggested 2-4 spaces for those nested if-statements. [2]

This commit redoes the replacement with 4 spaces.

[1]: https://www.gnu.org/software/make/manual/make.html#Conditional-Syntax
[2]: https://lore.kernel.org/all/CAHk-=whJKZNZWsa-VNDKafS_VfY4a5dAjG-r8BZgWk_a-xSepw@mail.gmail.com/

Suggested-by: Linus Torvalds <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
Makefile
arch/m68k/Makefile
arch/parisc/Makefile
arch/x86/Makefile
This page took 0.05684 seconds and 4 git commands to generate.