]> Git Repo - linux.git/commit
lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat
authorPaul Menzel <[email protected]>
Mon, 1 Jul 2024 15:58:01 +0000 (17:58 +0200)
committerAndrew Morton <[email protected]>
Sat, 6 Jul 2024 18:39:51 +0000 (11:39 -0700)
commit2fe29fe945637b9834c5569fbb1c9d4f881d8263
treefc6d713e063fa5bbbf4f6de27cd011ed5937191a
parentf442fa6141379a20b48ae3efabee827a3d260787
lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat

On a system with Perl 5.12.1, commit 5ef6dc08cfde
("lib/build_OID_registry: don't mention the full path of the script in
output") causes the build to fail with the error below.

     Bareword found where operator expected at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
     syntax error at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
     Execution of ./lib/build_OID_registry aborted due to compilation errors.
     make[3]: *** [lib/Makefile:352: lib/oid_registry_data.c] Error 255

Ahmad Fatoum analyzed that non-destructive substitution is only supported since
Perl 5.13.2. Instead of dropping `r` and having the side effect of modifying
`$0`, introduce a dedicated variable to support older Perl versions.

Link: https://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 5ef6dc08cfde ("lib/build_OID_registry: don't mention the full path of the script in output")
Link: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Paul Menzel <[email protected]>
Suggested-by: Ahmad Fatoum <[email protected]>
Cc: Uwe Kleine-König <[email protected]>
Cc: Nicolas Schier <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Ahmad Fatoum <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
lib/build_OID_registry
This page took 0.054132 seconds and 4 git commands to generate.