]> Git Repo - linux.git/commit
powerpc/preempt: Don't touch the idle task's preempt_count during hotplug
authorValentin Schneider <[email protected]>
Wed, 7 Jul 2021 18:38:31 +0000 (19:38 +0100)
committerMichael Ellerman <[email protected]>
Thu, 8 Jul 2021 13:38:10 +0000 (23:38 +1000)
commit2c669ef6979c370f98d4b876e54f19613c81e075
tree8148f1d88d6ca6a4981aca529833cc17724de70d
parent1df3af6dc3cfe643f43d46f202bd44861ccbdb99
powerpc/preempt: Don't touch the idle task's preempt_count during hotplug

Powerpc currently resets a CPU's idle task preempt_count to 0 before
said task starts executing the secondary startup routine (and becomes an
idle task proper).

This conflicts with commit f1a0a376ca0c ("sched/core: Initialize the
idle task with preemption disabled").

which initializes all of the idle tasks' preempt_count to
PREEMPT_DISABLED during smp_init(). Note that this was superfluous
before said commit, as back then the hotplug machinery would invoke
init_idle() via idle_thread_get(), which would have already reset the
CPU's idle task's preempt_count to PREEMPT_ENABLED.

Get rid of this preempt_count write.

Fixes: f1a0a376ca0c ("sched/core: Initialize the idle task with preemption disabled")
Reported-by: Bharata B Rao <[email protected]>
Signed-off-by: Valentin Schneider <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Tested-by: Bharata B Rao <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
arch/powerpc/platforms/cell/smp.c
arch/powerpc/platforms/pseries/smp.c
This page took 0.056851 seconds and 4 git commands to generate.