]> Git Repo - linux.git/commit
drm/i915: Disable intel HPD poll after DRM poll init/enable
authorImre Deak <[email protected]>
Thu, 4 Jan 2024 08:30:00 +0000 (10:30 +0200)
committerImre Deak <[email protected]>
Mon, 8 Jan 2024 16:51:31 +0000 (18:51 +0200)
commit24b412b1bfebb29ffca93bec215d26fd3a85a405
treeddf206c5beab46254b00e0a9e17cc6831642e25b
parenta1a0e8630711e404952e8d6485715183676b99f9
drm/i915: Disable intel HPD poll after DRM poll init/enable

The only purpose of intel_hpd_poll_disable() during driver loading and
system resume - at which point polling should be disabled anyway, except
for connectors in an IRQ storm, for which the polling will stay enabled -
is to force-detect all the connectors. However this detection in
i915_hpd_poll_init_work() depends on drm.mode_config.poll_enabled, which
will get set in drm_kms_helper_poll_init(), possibly after
i915_hpd_poll_init_work() is scheduled. Hence the initial detection of
connectors during driver loading may not happen.

Fix the above by moving intel_hpd_poll_disable() after
i915_hpd_poll_init_work(), the proper place anyway for doing the above
detection after all the HW initialization steps are complete. Change the
order the same way during system resume as well. The above race
condition shouldn't matter here - as drm.mode_config.poll_enabled will
be set - but the detection should happen here as well after the HW init
steps are done.

Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Jouni Högander <[email protected]>
Signed-off-by: Imre Deak <[email protected]>
drivers/gpu/drm/i915/display/intel_display_driver.c
drivers/gpu/drm/i915/i915_driver.c
This page took 0.080032 seconds and 4 git commands to generate.