]> Git Repo - linux.git/commit
x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page
authorKirill A. Shutemov <[email protected]>
Tue, 14 Jun 2022 12:01:35 +0000 (15:01 +0300)
committerDave Hansen <[email protected]>
Fri, 17 Jun 2022 22:37:33 +0000 (15:37 -0700)
commit1e7769653b06b56b7ea7d56911d2d5b2957750cd
tree25a3810999acb293a056132330d6c3b872fb850b
parentcdd85786f4b3b9273e4376e69aa95a2d71722764
x86/tdx: Handle load_unaligned_zeropad() page-cross to a shared page

load_unaligned_zeropad() can lead to unwanted loads across page boundaries.
The unwanted loads are typically harmless. But, they might be made to
totally unrelated or even unmapped memory. load_unaligned_zeropad()
relies on exception fixup (#PF, #GP and now #VE) to recover from these
unwanted loads.

In TDX guests, the second page can be shared page and a VMM may configure
it to trigger #VE.

The kernel assumes that #VE on a shared page is an MMIO access and tries to
decode instruction to handle it. In case of load_unaligned_zeropad() it
may result in confusion as it is not MMIO access.

Fix it by detecting split page MMIO accesses and failing them.
load_unaligned_zeropad() will recover using exception fixups.

The issue was discovered by analysis and reproduced artificially. It was
not triggered during testing.

[ dhansen: fix up changelogs and comments for grammar and clarity,
   plus incorporate Kirill's off-by-one fix]

Signed-off-by: Kirill A. Shutemov <[email protected]>
Signed-off-by: Dave Hansen <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
arch/x86/coco/tdx/tdx.c
This page took 0.060938 seconds and 4 git commands to generate.